Theia: cannot clean terminal with keybindings anymore

[akosyakov]

Keybinding service waits for next chord. Caused by changes in this line: https://github.com/eclipse-theia/theia/commit/582ae9dd88a58f3053e9445199ee54e42179923f#diff-0291e1b92ff01c13c0dc1c98263ac426R631

cc @vinokurig

[akosyakov]

That's possibly critical if none of terminal keybinding are working anymore. I suggest we revert this line and someone else will need to look into support of emacs vscode extension without breaking terminals again.

[vinokurig]

I am working on it.

[akosyakov]

@vinokurig ok, do you have estimation when it can be fixed?

[vinokurig]

@akosyakov I am going to open a PR today

[akosyakov]

@vinokurig how are you going to fix it? I was thinking try to check whether there is at least one partial keybinding which is active, i.e. its context/when closure evaluates to true, instead of checking only for existence.

[vinokurig]

@akosyakov The PR is ready