Theia: Find in Folder - no results
Description
When using the "Find in Folder" option, no results are returned. The files can be found is searching all files, just not when searching specific directories.
Reproduction Steps
- Copy text from file
- Right click on a parent folder and click "Find in Folder"
- Paste text and search
OS and Theia version:
- Ubuntu
- Che-Theia@f3c54f1 using Theia@39d6cc67
List of extensions:
- @theia/core 0.14.0
- @theia/output 0.14.0
- @theia/process 0.14.0
- @theia/filesystem 0.14.0
- @theia/variable-resolver 0.14.0
- @theia/workspace 0.14.0
- @theia/languages 0.14.0
- @theia/editor 0.14.0
vseager
All 20 comments
Thank you for the issue! Could you please define reproducible steps for the example app running from sources?
akosyakov
on 17 Jan 2020
@akosyakov I'm sorry I'm an end user and not sure what you mean by this. I've already explained the issue the best I can and included a screencast so hopefully this helps you find a resolution.
vseager
on 17 Jan 2020
@vseager it would be nice if you can provide the link to the source code (like a github repository if it's public) and the string that you're searching with text format in the issue.
benoitf
on 17 Jan 2020
@benoitf The repository is private but the project is a Magento project (https://github.com/magento/magento2/) . You could replicate the issue by searching for any term, for example if you were trying to find the string "class DefaultConfigProvider" in the file https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Checkout/Model/DefaultConfigProvider.php by searching within one of it's parent directories.
vseager
on 17 Jan 2020
I tried reproducing using the steps provided, I used Eclipse Theia to reproduce it, and the issue seems to be resolved already. The "Find in Folder" works perfectly fine in theia.
Anasshahidd21
on 21 Jan 2020
@Anasshahidd21 It is still an issue for me. Which version of Theia are you testing it in?
vseager
on 30 Jan 2020
@Anasshahidd21 this seems to happen only in the vendor folder. I think the logic needs to be changed so that when explicitly searching "in folder", it ignores any ignore rules?
davidwindell
on 3 Feb 2020
it ignores any ignore rules?
probably if you search in ignored folder only
akosyakov
on 3 Feb 2020
Yeah, I think that's what it's doing and that should be changed?
davidwindell
on 3 Feb 2020
I meant currently one cannot search in ignored folder, but we could suppress ignore filter if we detect that a search is started in such folder.
akosyakov
on 4 Feb 2020
That would be awesome!
davidwindell
on 4 Feb 2020
I meant currently one cannot search in ignored folder, but we could suppress ignore filter if we detect that a search is started in such folder.
I thought this was already the case (https://github.com/eclipse-theia/theia/issues/3917#issuecomment-450914317). If I search globally, the search will respect the .gitignore. If I narrow down the search to explicitly choose a directory to search from (find in folder), I do successfully get results from said folder.
_Search Globally_:
_Searching Specifically in 'tmp/*' returns me gitignored results_:
vince-fugnitto
on 17 Feb 2020
This doesn't work for me on the latest Eclipse Che, Theia@e1d08d00
davidwindell
on 19 Feb 2020
Doesn't work for me either!
vseager
on 19 Feb 2020
This is getting really annoying as a lot of code we search for is in the vendor/ folder, should we raise it on the eclipse/che repo instead?
davidwindell
on 21 May 2020
This is getting really annoying, should we raise it on the eclipse/che repo instead?
I'm sorry, the community has been busy with other priorities (marked by the 'help wanted' label)
If the issue is important to you please don't hesitate to open a pull-request to resolve it.
vince-fugnitto
on 21 May 2020
Can you confirm if this is a Che or Theia issue?
davidwindell
on 21 May 2020
Can you confirm if this is a Che or Theia issue?
@davidwindell I see that in theia, if we search for a term that is in an ignored folder/file (ex: file under node_modules), performing a 'search-in-workspace' does not yield any results unless we explicitly set 'include ignored files' option (eye icon):
_Searching Without 'Include Ignored Files'_
_Searching With 'Include Ignored Files'_
vince-fugnitto
on 21 May 2020
Ah, that does seem to help! I apologise for not spotting the eye icon. It does feel odd that when you explicitly request a folder to include it still excludes it without manual action. Let's go ahead and close this issue now.
davidwindell
on 22 May 2020
Ah, that does seem to help! I apologise for not spotting the eye icon. It does feel odd that when you explicitly request a folder to include it still excludes it without manual action. Let's go ahead and close this issue now.
Closing.
vince-fugnitto
on 20 Aug 2020
jankeromnes
路
tetchel
路
jeanlucburot
路
marechal-p
路
Most helpful comment
@benoitf The repository is private but the project is a Magento project (https://github.com/magento/magento2/) . You could replicate the issue by searching for any term, for example if you were trying to find the string "class DefaultConfigProvider" in the file https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Checkout/Model/DefaultConfigProvider.php by searching within one of it's parent directories.