Theia: Update of preferences from VSCode plugin triggers multiple overwrite popup confirmation

Created on 8 Jan 2020  路  6Comments  路  Source: eclipse-theia/theia

Description

It seems there is an inconsistency between the vscode.workspace.getConfiguration().update API in VSCode and Theia.
Even though there are no changes in the configuration, the update is triggered and is trying to overwrite the contents in the settings.json file.

Is there a way to turn off the overwrite confirmation?
Is this a bug in the FileSystem watcher?

Reproduction Steps

Extension: Zowe Explorer
Whenever the browser is refreshed or left idle for a while, the following popup appears multiple times:
overwrite

OS and Theia version:
Windows 10
latest Theia

bug preferences vscode

All 6 comments

@vince-fugnitto yes, I think the fix should handle both cases

@akosyakov - The above mentioned error message is happening very frequently. Our end users/customers of Zowe Explorer are experiencing this a lot and are complaining about it. Wondering if there is a workaround of some sort to at least minimize the frequency of the pop up, while you are working on the fix?

@akosyakov - The above mentioned error message is happening very frequently. Our end users/customers of Zowe Explorer are experiencing this a lot and are complaining about it. Wondering if there is a workaround of some sort to at least minimize the frequency of the pop up, while you are working on the fix?

I think if you don't want to display the dialog any longer until there is a proper fix, you can unbind the following:

https://github.com/eclipse-theia/theia/blob/554f99edf3f0c98a87986686aa8aa9bfcfcba4f2/packages/filesystem/src/browser/filesystem-frontend-module.ts#L44-L53

@vince-fugnitto - Thank you, we will try that.

I had to fix tests yet, but could someone try please whether you can reproduce it with https://github.com/eclipse-theia/theia/pull/7110?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tetchel picture tetchel  路  3Comments

vinokurig picture vinokurig  路  3Comments

jankeromnes picture jankeromnes  路  3Comments

akosyakov picture akosyakov  路  3Comments

akosyakov picture akosyakov  路  3Comments