Theia: Variables View Loses Expansion State when Stepping

Created on 19 Nov 2019  路  11Comments  路  Source: eclipse-theia/theia

Description

When using the resume, step next or step in functions, the scope tree in the Variables view refreshes completely in Theia, this leads to a collapsed tree, while the tree in VSC remains to the previous state and leaves any expanded part as it is, by just refreshing whatever needs to. Is there a way to do the same in Theia?

Reproduction Steps

Start a debug session using DAP through Theia. When stopped in a specific breakpoint expand the scope and maybe some of the variables. Resume or step in or step over to the next breakpoint. The variable tree is completely disappearing and reappearing (really fast) and thus it is collapsed to the original scope only

Windows 10 and Theia version: 0.11.0

Diagnostics:
No diagnostics

needs more info bug debug help wanted

Most helpful comment

Changed the title to reflect the problem being described. Yeah, this behaviour is annoying.

All 11 comments

Changed the title to reflect the problem being described. Yeah, this behaviour is annoying.

I can't reproduce. Is it os or browser specific issue?
screencast-localhost_3000-2019 12 04-17_20_38

@ParOvBroadcom Is it still actual?

It could be timing issue, we debounce with 400ms: https://github.com/eclipse-theia/theia/blob/dbe5b5aab829a0ac1ca81193089cf0e0ca1aa384/packages/debug/src/browser/view/debug-variables-source.ts#L41

@ParOvBroadcom Could you provide more concrete steps?

Maybe it is not even reproducible locally (i.e. VS Code does not do a remote call), but with some latency. @ParOvBroadcom Do you run locally?

It doesn't work properly in either way (resume or step over)
First having a running session
1
Then expanding the local variables
2
Clicking on Resume
3
It collapses the Local variables
4
Expanding again the variables
5
Clicking on step over
6
Collapses the local variables also
7

@ParOvBroadcom Is there a way to run your debug adapter or reproduce without it? It does not seem to happen with other.

@akosyakov What do you mean without "it"? This happens in Theia, but not in VScode.

We need a debugger to reproduce the issue,
It can't be reproduced neither with node nor java debug.

It could be timing issue, we debounce with 400ms:

https://github.com/eclipse-theia/theia/blob/dbe5b5aab829a0ac1ca81193089cf0e0ca1aa384/packages/debug/src/browser/view/debug-variables-source.ts#L41

I increase debounce and it makes things better.
@akosyakov seems you right about it. We have pretty big delays in communication to target.

@tolusha, unfortunately, we can't provide our debugger.

@ishche How much do you need to increase?

@akosyakov
@ishche
I've submitted a draft PR to check if proposed solution make sense.
https://github.com/eclipse-theia/theia/pull/6734

Was this page helpful?
0 / 5 - 0 ratings

Related issues

marechal-p picture marechal-p  路  3Comments

dhananjayharel picture dhananjayharel  路  3Comments

vinokurig picture vinokurig  路  3Comments

jankeromnes picture jankeromnes  路  3Comments

cekvenich picture cekvenich  路  3Comments