Theia: Useful commands not available from context menu

[lmcbout]

Description

Between Theia version 0.8.0 and 0.9.0, we lost some functionalities

Version 0.8.0

Explorer view and project are on two lines

• Able to see the path of the project in workspace (When hovering)
• Able to call the command "Compare with" from the context menu of the explorer view
• Able to call the command "Add Folder to workspace" from the context menu

Version 0.9.0

Explorer view and project are on same line

• No tool-tip for the workspace project path
• Context menu in the explorer view not showing command options

In both versions, we can call the commands: "Add Folder to Workspace" and "Git:diff" from the quick open menu, but not from the context menu with version 0.9.0

Note: If you add a new root folder, then the menu becomes accessible from each root folder because the view is modified. Explorer view and project are on separate line.

Reproduction Steps

Version 0.8.0

Version 0.9.0

OS and Theia version:
Theia version 0.8.0 and version 0.9.0
OS: Ubuntu 16.04

Diagnostics:

[akosyakov]

@lmcbout What about master state? Do you want to have 0.9.1 or just 0.10.0?

[vince-fugnitto]

@lmcbout we have aligned our behavior with VSCode and now support more complex views for the explorer (ability to add sub-views such as npm scripts). VSCode also does not show the project path when hovering over the title. The command Add Folder to Workspace is also present in the explorer, just not from the root node (empty area or quick-open command menu).

What do you think should be done?

[akosyakov]

@vince-fugnitto view containers are not part of 0.9.0, they will be available only in 0.10.0

[lmcbout]

@akosyakov @vince-fugnitto No need to create a 0.9.1,version 0.10.0 is fine
Where do we see the project path! the only place to see it was when hovering over the workspace, not the view. Also, when we add a root workspace, then the menu becomes available as before. The way to see the new view is on the context menu of the view, not the workspace bar . Since the two lines (Workspace + view) are grouped together initially until we add a new root, the menu is not available.
I am preparing also a new issue about "Drag & drop | copy" a file to the root folder is not possible anymore in version 0.9.0

[vince-fugnitto]

@vince-fugnitto view containers are not part of 0.9.0, they will be available only in 0.10.0

When running master the about dialog displays 0.9.0.
I believe @lmcbout tested the latest master.

[vince-fugnitto]

Where do we see the project path?

Where do we see the workspace path in VSCode?

[lmcbout]

If VSCode does not show the workspace path, then Theia should not show it even if it was showing before !
You mean that Theia should always be less than VSCode !

[lmcbout]

Yes, version 0.9.0 I am using is based on this morning commit

[vince-fugnitto]

If VSCode does not show the workspace path, then Theia should not show it even if it was showing before !
You mean that Theia should always be less than VSCode !

I don't quite understand what you mean by we should be less than VSCode.
I'm just stating that we had recent developments to align our views https://github.com/theia-ide/theia/pull/5665 with that of VSCode and support plugins. This means that we are closer to VSCode, and of course things will change (and more is supported). If VSCode does not display the workspace path in a single-root workspace, then I'd expect that after aligning we don't either.

[vince-fugnitto]

Yes, version 0.9.0 I am using is based on this morning commit

This morning's commit is 0.10.0 not 0.9.0.
0.9.0 was released on https://github.com/theia-ide/theia/commit/5c298024b5f5d705e6a53eaeb4660083350be91b

[lmcbout]

I don't quite understand what you mean by we should be less than VSCode.

Whether we are in a single root or multi-root, Theia should show the workspace path. If VSCode is not showing it in a single root, it is mistake.

[akosyakov]

@vince-fugnitto Cannot really grasp are here issues apart from with the title?

[vince-fugnitto]

@akosyakov from what I gather, @lmcbout would like to include the workspace path when hovering over the widget title (in the case of a single-root workspace). It'd be a lot easier to track the issues separately I think.

[lmcbout]

I think this issue could be resolved if we continue to use two separated lines , one for the view with it own context menu and one for the workspace with its own context menu. Then whether we use a single or multi-root workspace, we always get the appropriate functionality

[vince-fugnitto]

I think this issue could be resolved if we continue to use two separated lines , one for the view with it own context menu and one for the workspace with its own context menu. Then whether we use a single or multi-root workspace, we always get the appropriate functionality

Can you clarify what you mean by view an workspace lines?
Do you mean have the Explorer title, and then lower keep the workspace root node in the tree?
If so, it defeats the purpose of the recent changes and alignment effort.

[vince-fugnitto]

@akosyakov I have a working poc which adds titles for sidebar panels, and in the case of the explorer I display the path. Is it acceptable?


[lmcbout]

@vince-fugnitto the POC just above seems to fix a portion of the issue, what about the commands in the context menu? Also, do you have a DROP zone to drop files at the root level ( issue #5947 ) when you only have a single root !

[vince-fugnitto]

@vince-fugnitto the POC just above seems to fix a portion of the issue, what about the commands in the context menu? Also, do you have a DROP zone to drop files at the root level ( issue #5947 ) when you only have a single root !

I never mentioned the POC fixing all issues, the POC only addresses the 'title'.
For the context menu, what do you believe should be included that cannot be performed by other means?

[vince-fugnitto]

Also, do you have a DROP zone to drop files at the root level ( issue #5947 ) when you only have a single root !

I asked in #5947 if you'd like to handle the dnd.

[lmcbout]

The POC addresses the "title", I think we need to look for a global solution which will include the "title", the context menu" and the issue #5947
The context menu for the "Explorer " view will be useful, but I don't think it should include the context menu for the workspace under the same menu. (which is missing now)

it defeats the purpose of the recent changes and alignment effort.

You asked If I wanted to handle issue #5947 I think whoever will handle the issue will need to use the tree to handle it, so it might means to revert portion or all the related issue you talked about .
Also, it will probably collide with this current issue.

[vince-fugnitto]

The POC addresses the "title", I think we need to look for a global solution which will include the "title", the context menu" and the issue #5947

I updated the 'title' because it is present in VSCode so we can now support it.
All widgets present in the sidebar that display a 'header' will now have a title attribute.

The context menu for the "Explorer " view will be useful, but I don't think it should include the context menu for the workspace under the same menu. (which is missing now)

I'm not sure where this context menu should be? I also don't know what items to include in it.
The view integration provides a context menu to show/hide integrations to the view.

You asked If I wanted to handle issue #5947 I think whoever will handle the issue will need to use the tree to handle it, so it might means to revert portion or all the related issue you talked about .
Also, it will probably collide with this current issue.

I don't think there is a collision at all. Enabling DnD for the root will not interfere with pre-existing issues. What needs to be reverted?

[akosyakov]

I'm not sure where this context menu should be? I also don't know what items to include in it.
The view integration provides a context menu to show/hide integrations to the view.

Could we add actions to more context menu of the title toolbar?

[akosyakov]

@vince-fugnitto Where can I see source code of a POC? Does it rely on caption of a part widget similarly to a title? If so we can do it.

[vince-fugnitto]

@vince-fugnitto Where can I see source code of a POC? Does it rely on caption of a part widget similarly to a title? If so we can do it.

I added the PR here https://github.com/theia-ide/theia/pull/5948

[akosyakov]

@vince-fugnitto Is it clear what I mean under: https://github.com/theia-ide/theia/issues/5946#issuecomment-521585267

So like in SCM:

[vince-fugnitto]

@vince-fugnitto Is it clear what I mean under: #5946 (comment)

So like in SCM:

Yes, I understood the ... toolbar item displaying the More context-menu :)

[vince-fugnitto]

@akosyakov I'll extract the feature into it's own issue so we can track who's working on it and what items should be displayed in the menu.

[vince-fugnitto]

Opened the issue #5951 to track it.

[vince-fugnitto]

Closing the issue as:

• displaying the workspace uri has been fixed https://github.com/theia-ide/theia/pull/5948
• additional workspace commands are being tracked separately with #5951 (_more_ toolbar item)