Theia: [pluginExt] npm scripts showed when config.npm.enableScriptExplorer is false after npm extension installed

Created on 5 Aug 2019  路  2Comments  路  Source: eclipse-theia/theia

Description

when I installed npm extension from vscode, ther npm scripts eabled in the explorer widget, no matter what the value of config.npm.enableScriptExplorer is .

image
but the view should be enabled when config.npm.enableScriptExplorer is true
image

Reproduction Steps

  • install the npm version to theia plugins dir.
  • compile the latest theia, and start theia example app.
    OS and Theia version:
    theia version: the latest version (b40a8d54380524dd1a8b05992ebf540b68806e92)
    Diagnostics:
bug shell vscode

Most helpful comment

It is the view container issue. @AlexTugarev was mentioning that when closure is ignored. I will do a PR promptly.

All 2 comments

@kpge Would you like to investigate?

cc @elaihau

It is the view container issue. @AlexTugarev was mentioning that when closure is ignored. I will do a PR promptly.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dhananjayharel picture dhananjayharel  路  3Comments

vince-fugnitto picture vince-fugnitto  路  3Comments

kpge picture kpge  路  3Comments

vince-fugnitto picture vince-fugnitto  路  3Comments

akosyakov picture akosyakov  路  3Comments