Theia: TreeItem on click commands don't work

[tetchel]

With #5661 in, commands no longer break the tree, but the commands do not work (they never execute, so I assume there is just no listener).

In VS Code, single-clicking a tree item runs the command tied to it, eg opening a file in the Explorer view.
This can be configured to be double-click instead with the setting workbench.list.openMode. (see https://github.com/Microsoft/vscode/issues/39601)

TreeItem onclick commands do not appear to have any effect in Theia.

[vince-fugnitto]

@tetchel which command were you attempting to execute with the tree?

[tetchel]

A custom one from my extension

Edit: also revealInExplorer, not sure if Theia has that builtin.

[vince-fugnitto]

Edit: also revealInExplorer, not sure if Theia has that builtin.

We do have the command Reveal in Explorer
https://github.com/theia-ide/theia/blob/d4a15ad515666ead71556faf04c226d9157d3a33/packages/navigator/src/browser/navigator-contribution.ts#L38

[tetchel]

hmm, that is a different command ID than vs code (again, revealInExplorer), perhaps that should be a separate issue.

[vince-fugnitto]

hmm, that is a different command ID than vs code (again, revealInExplorer), perhaps that should be a separate issue.

I believe it will be, it's part of the https://github.com/theia-ide/theia/pull/5590 change :)

[akosyakov]

@tetchel Can it be closed by https://github.com/theia-ide/theia/pull/5961? Could you verify please?

[tetchel]

Indeed this is fixed in 0.10, thanks guys