Theia: [terminal] IDE freezes with bad preference setting

[svenefftinge]

A setting of "terminal.integrated.lineHeight": 0 causes the IDE to freeze on load.

[akosyakov]

@svenefftinge How critical is it? Should i have a look?

[svenefftinge]

Not super critical as it only happens in a very rare case. But when it happens its a show stopper. So we should look at it soon.

[uniibu]

I stupidly set this to test on my gitpod workspace's user settings and now I can't open any repo from github or any previous workspace on gitpod. So basically, i can't use gitpod anywhere lol. @svenefftinge or @akosyakov have any idea?

[akosyakov]

@uniibu i will ask @svenefftinge to clean your user settings when he is around

[uniibu]

Ok, I was able to put back the terminal.integrated.lineHeight to 1 by manually editing the settings.json for a workspace/repo and opening that on gitpod, so it overrides the user settings.

[toonvd]

It also crashed when I accidentally set my terminal font size to 1. So I think it is a general issue.

[uniibu]

I think its best to set a minimum hard limit for these settings to avoid crashing.

[akosyakov]

@uniibu Could you take care about it? something like Math.max(lineHeight, 1) should do?

[uniibu]

@uniibu Could you take care about it? something like Math.max(lineHeight, 1) should do?

We actually have minimum property for preferences, so setting this would suffice. Created PR #4801