Thanos: Add proposal to remove Gossip

Created on 23 Aug 2018  路  7Comments  路  Source: thanos-io/thanos

Additionally fix https://github.com/improbable-eng/thanos/blob/master/docs/getting_started.md#communication-between-components ASAP to stop confusion around which component should talk with which component.

feature request / improvement

Most helpful comment

It would actually be nice to have support for DNS-based SD, so we could provide a single FQDN, e.g. --store stores.thanos.mycompany.org (which can be under Consul, if needed), for the querier, which would resolve and use all the IP resolved under the DNS name. 馃檪

All 7 comments

Is there a planned replacement or will static addresses be the only option?

All will be covered by proposal (:

TL;DR: File SD is planned as a replacement. (Only on querier and ruler, as those only requires such logic)

It would actually be nice to have support for DNS-based SD, so we could provide a single FQDN, e.g. --store stores.thanos.mycompany.org (which can be under Consul, if needed), for the querier, which would resolve and use all the IP resolved under the DNS name. 馃檪

Done.

Doesn't seems to be a well thought decision to remove autodiscovery for tool that supposed to be used in dynamic environments like aws with instances going up and down for whatever reason.

@drax68 did you have a chance to read the proposal? DNS discovery gives exactly the same dynamicity without massive overhead (and other disadvantage mentioned in document) of gossip protocol (:

Let me know if any other functionality is missing.

Proposal completed.

Was this page helpful?
0 / 5 - 0 ratings