Reference from TensorFlow: https://www.tensorflow.org/api_docs/cc/class/tensorflow/ops/matrix-band-part
This op is used by the Music Transformer model.
annxingyuan
All 7 comments
Is this issue taken?
If not I can get an implementation ready by tomorrow hopefully!
Kriyszig
on 4 Oct 2019
@Kriyszig Fantastic! It's all yours :)
annxingyuan
on 4 Oct 2019
PR#1520 from January already implemented tf.linalg.bandPart. It is purely based on existing tfjs operations and, according to some quick and dirty benchmarks, it is around 10 times slower than a backend-based implementation, which should be acceptable for an O(m*n) operation. I've taken the liberty to add PR#2155 to the benchmark here. PR#2155 currently seems to have some performance issues caused by the way that concat is used.
DirkToewe
on 16 Oct 2019
@DirkToewe, Can you port PR#1520 to this monorepo? Your implementation scales really well unlike mine.
Kriyszig
on 16 Oct 2019
Okay, will do as soon as I can.
DirkToewe
on 16 Oct 2019
Done! You can find the PR here. @Kriyszig Your PR had better documentation and more tests so I've based my PR on it. If that's okay with You, You just need to to give Your consent in the PR.
DirkToewe
on 17 Oct 2019
Seems like this can be closed now, thanks to #2226?
hrldcpr
on 6 Feb 2020
Related issues
weiji14
路
3Comments
dhrumil83
路
3Comments
ritikrishu
路
4Comments
Josef-Haupt
路
3Comments
RELNO
路
3Comments
Most helpful comment
Okay, will do as soon as I can.