Tfjs: Support tf.spectral.ifft, tf.spectral.rfft and tf.spectral.irfft

Created on 11 Oct 2018  路  10Comments  路  Source: tensorflow/tfjs

Currently we only support tf.spectral.fft(), we should support tf.spectral.ifft, tf.spectral.rfft and tf.spectral.irfft.

Most helpful comment

This is done.

All 10 comments

cc @Lewuathe

As long as I understand correctly, rfft is just a subset of fft, while the other two may need separated implementation.

Anyway, I'm going to work on this.

Awesome @Lewuathe! BTW, we should fix this first (so it works for all the other ops too): https://github.com/tensorflow/tfjs/issues/781

That makes sense. I'll take a look.

I'm going to knock these off since there's a Google team that wants these ops soon :)

@nsthorat Are you working on tf.spectral.rfft and tf.spectral.irfft too?

@Lewuathe I haven't started yet! If you want to take this, go ahead if you think it will be in the near term future :) Note that this is not exactly the same as real(fft(x)).

This is done.

@nsthorat great news. Does this mean I could expect signal.inverse_stft to work on tfjs?

These ops aren't supported yet (just the ones listed on this issue).

I filed a new issue for those ops: https://github.com/tensorflow/tfjs/issues/1362

Was this page helpful?
0 / 5 - 0 ratings