Tf-operator: Rename this repo

Created on 13 Aug 2021  Â·  16Comments  Â·  Source: kubeflow/tf-operator

Once the unified operator is in place, we should probably rename the repo so that it's no longer specific to TensorFlow.

We can use this issue to discuss details.

/cc @kubeflow/wg-training-leads

@kubeflow/project-steering-group What's the process like to get this repo renamed?

kindiscussion

Most helpful comment

training-operator LGTM.

All 16 comments

ping @kubeflow/project-steering-group

Also, need to ensured that prow settings are correctly reflected when repo name is changed

hi there -- I think first we should figure out where there are mentions of
tf-operator everywhere (code, docs, etc) so we can update accordingly. What
is the new name you were thinking of?

On Thu, Aug 19, 2021 at 1:33 AM Johnu George @.*>
wrote:

Also, need to ensured that prow settings are correctly reflected when repo
name is changed

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/tf-operator/issues/1348#issuecomment-901719329,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABREJVOT37FWCKXT5TDTQBTT5S6T5ANCNFSM5CCND6RA
.

Perhaps "training-operator" or "training-operators"? Any suggestions? @kubeflow/wg-training-leads

We can update the docs later once the repo is renamed. GitHub will auto-redirect to the new URL so we don't have to worry about breaking existing links.

training-operator LGTM.

LGTM as well, but I'll wait for @bobgy to confirm. As long as we have a
plan to update documentation right after. I believe we can easily handle
repo rename.

On Thu, Aug 19, 2021 at 6:56 PM Ce Gao @.*> wrote:

training-operator LGTM.

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/tf-operator/issues/1348#issuecomment-902370990,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABREJVLNUV54VADRAWYEMRTT5WY6LANCNFSM5CCND6RA
.

+1 on training-operators (or training-operator is there is a good reason not be plural), @kimwnasptd will this change impact manifests ?

Related: https://github.com/kubeflow/manifests/issues/1962

manifests are already taken care of

We will update docs after the rename @theadactyl @Bobgy

LGTM too, let me confirm with other PSG members in the next meeting.

It would be helpful preparing a plan with when to rename and what should happen after the rename, so that everyone is better prepared for the change.

Hi @kubeflow/wg-training-leads!
I've brought this up to discuss in PSG, there are no concerns.

To proceed, I'd suggest preparing a plan and inform me what date you want the rename to happen.

And the final name I believe is "training-operator", refer to https://github.com/kubeflow/tf-operator/issues/1348#issuecomment-902370990.

Thanks @Bobgy.

@kubeflow/wg-training-leads anyone has bandwidth to drive the efforts?

Prow changes is the main area of concern. I hope, we can resolve all issues once repo is renamed.

Other than docs and prow changes, Is there anything else to be taken care of ? Since web redirect works by default, many things are automatically taken care of.

As manifests are already updated, release deadlines should not be affected by this as well. @kimwnasptd

I can help on this to completion.

And, I am not sure if affects katib or other projects who use tfjob api types.

And, I am not sure if affects katib or other projects who use tfjob api types.

We are using only Training Operator CR names, and they will not be renamed.
So Katib should not be affected.

Was this page helpful?
0 / 5 - 0 ratings