Testcontainers-java: Why some classpath properties are ignored?
Hello.
Thank you for your work and project.
Why some properties (more interesting in checks.disable) are ignored from classpath?
What's the point?
If I don't want disable docker check globally, but for my specific project, why I can't?
(I saw reasoning in https://github.com/testcontainers/testcontainers-java/pull/1784, but didn't understand these)
mxv2
All 4 comments
Because there are environment-specific properties. If you disable them per project, then other users of that project (especially the ones who just cloned it for the first time) may experience issues and will miss some helpful information that the checks provide.
Duplicate of #2312.
bsideup
on 19 Feb 2020
Okay, I know reason now, it's good point.
But I didn't understand from documentation that checks.disable is only environment setting.
And I spent a lot of time because of this misusing.
Will you accept PR with warning log about this misusing properties (and fix doc maybe)?
mxv2
on 19 Feb 2020
@mxv2 absolutely! 馃挴
Even more - we already discussed this idea, see this thread https://github.com/testcontainers/testcontainers-java/pull/1781#discussion_r369165730 for the details :)
bsideup
on 19 Feb 2020
And sorry that it caused a time waste for you 鈽猴笍
bsideup
on 19 Feb 2020
Related issues
denis-zhdanov
路
3Comments
lovepoem
路
3Comments
kiview
路
3Comments
richard77
路
3Comments
aniketbhatnagar
路
3Comments
Most helpful comment
Okay, I know reason now, it's good point.
But I didn't understand from documentation that checks.disable is only environment setting.
And I spent a lot of time because of this misusing.
Will you accept PR with warning log about this misusing properties (and fix doc maybe)?