Test-infra: area/* and sig/* labels are not removed from PRs when they are not needed

Created on 20 May 2020 · 8Comments · Source: kubernetes/test-infra

What happened:
When I worked on a PR in k8s test-infra, I made some mistake during rebase and pushed a lot of irrelevant changes, which exploded the labels on the PR. But after I corrected it and did a force push, the labels were not removed, though my PR did not contain those changes any more.

What you expected to happen:
The labels should be removed after the PR does not contain the relevant files changes.

How to reproduce it (as minimally and precisely as possible):
Make some change on a PR that gets Prow adding some labels based on the OWNERS file, and then revert the change.

Please provide links to example occurrences, if any:
The example PR is https://github.com/kubernetes/test-infra/pull/17568.

/area prow

areprow kinbug lifecyclrotten

Source

chizhg

Most helpful comment

That’s my feeling too. It’s annoying when a rebases goes sideways and you manually have to remove the labels, but probably not worth the effort to work around this IMO

cblecker on 22 May 2020

👍2

All 8 comments

it would be feasible enough to detect that a push removed the need to add these, but these labels can also be added manually or via commands, so it would be somewhat complex to get that correct (so as not to remove manually added labels) or we'd have to decide that we're OK with clobbering manually added labels.

cc @cblecker for behavior thoughts

BenTheElder on 22 May 2020

Yeah, unless we can figure out some way of saying "these ones are manual, and these ones are from owners files" then I think it might do more harm than good to clobber manually added labels.

cblecker on 22 May 2020

👍1

it should be possible to detect that I think, but you'd have to read in the PR events and compute what happened, I sort of doubt any of the prow maintainers are inclined to build this more complex version.

BenTheElder on 22 May 2020

That’s my feeling too. It’s annoying when a rebases goes sideways and you manually have to remove the labels, but probably not worth the effort to work around this IMO

cblecker on 22 May 2020

👍2

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 20 Aug 2020

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 19 Sep 2020

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

fejta-bot on 19 Oct 2020

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.