Test-infra: plank reports cannot apply changes reported at error level

[fejta]

It seems like this is an expected state of affairs? Since crier etc can also update the object.

Can we report this at a info level unless its a consistent problem?

/area prow
/area prow/plank
/kind oncall-hotlist

/cc @stevekuznetsov @cjwagner

{
 insertId: "1fmajjkg10u0n5f"  
 jsonPayload: {
  component: "plank"   
  error: "errors syncing: [Operation cannot be fulfilled on prowjobs.prow.k8s.io "7709fdf4-eb9a-11e9-9232-aacf8944b3c6": the object has been modified; please apply your changes to the latest version and try again], errors reporting: []"   
  file: "prow/cmd/plank/main.go:144"   
  func: "main.main.func2"   
  level: "error"   
  msg: "Error syncing."   
 }
 labels: {…}  
 logName: "projects/k8s-prow/logs/plank"  
 receiveTimestamp: "2019-10-10T20:14:24.103165269Z"  
 resource: {
  labels: {
   cluster_name: "prow"    
   container_name: "plank"    
   instance_id: "6617373689885452859"    
   namespace_id: "default"    
   pod_id: "plank-6655fd65bf-t88s5"    
   project_id: "k8s-prow"    
   zone: "us-central1-f"    
  }
  type: "container"   
 }
 severity: "ERROR"  
 timestamp: "2019-10-10T20:14:18Z"  
}

[cblecker]

/honk

[k8s-ci-robot]

@cblecker:

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta]

/honk

[k8s-ci-robot]

@fejta:

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cjwagner]

/honk
/honk
/honk
/honk

[k8s-ci-robot]

@cjwagner:

In response to this:

/honk
/honk
/honk
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ixdy]

/honk

[k8s-ci-robot]

@ixdy:

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cblecker]

/honk

[k8s-ci-robot]

@cblecker:

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nikhita]

/honk

[k8s-ci-robot]

@nikhita:

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eloyekunle]

/honk

[k8s-ci-robot]

@eloyekunle:

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevekuznetsov]

Shouldn't this have been solved with the PATCH? @krzyzacy

[krzyzacy]

yes? looks like it's not?

[fejta]

/assign @krzyzacy @stevekuznetsov @cjwagner

Any chance we can get some progress on this PR? Asking on behalf on oncall :innocent:

[krzyzacy]

@stevekuznetsov it's only on aborted jobs, looks like there's some other places that's changing the prowjob fields

[stevekuznetsov]

Are we not using PATCH in every case?

[krzyzacy]

Is abort handled differently?!

[krzyzacy]

https://github.com/kubernetes/test-infra/blob/bce66e123dad88cbeacc91d800dad305c80bb393/prow/pjutil/abort.go#L55-L123

:disappointed:

[fejta]

So we need to update that, right? Is this sinker, plank or both?

[krzyzacy]

https://github.com/kubernetes/test-infra/blob/bce66e123dad88cbeacc91d800dad305c80bb393/prow/pjutil/abort.go#L116 this line need to use patch, instead of update

I can PR when I find coding time.