Test-infra: Remove milestonestatus prow plugin

[spiffxp]

What should be cleaned up or changed:

The milestonestatus plugin should go away.

Provide any links for context:

Don't have the issue(s) handy right now, but we stopped using status/foo labels (they've been removed from label_sync) so /status doesn't mean anything to us, and the milestone plugin does what we need for /milestone

There are repos that "use" it in that they have it enabled in plugins.yaml, but that's just due to cargo culting, I couldn't find any actual status labels in use.

/area prow
/sig release
/sig testing

[spiffxp]

/milestone v1.14
/good-first-issue
FWIW I'm pretty sure this is a straightforward fix if someone wants to give it a shot. First contribution as net-negative lines FTW!

[munnerz]

We've recently enabled this plugin along with a few other milestone related ones.

We've not collectively as a team made much use of it yet, but this issue does raise a larger question for me around what Prow intends to be wrt versions and stability.

I understand that changes like removing 'run_after_success' are required in order to facilitate other new features, but this reads more like it's being removed because it isn't utilised by prow.k8s.io anymore.

I'm used to having to deal with breaking changes between bumps of Prow, but I think for a lot of people evaluating Prow this could put them off.

What's the deprecation strategy for things like this? Can old plugins be moved into a 'contrib/' dir as external plugins with limited support, assuming k/test-infra no longer wants to support it? 🙂

[stevekuznetsov]

We can also just keep it around? It doesn't cost us any maintenance burden AFAICT

[BenTheElder]

this came up because I wasn't aware we didn't want to use it anymore and
approved a PR enabling it for one of the k8s repos along with other config
changes. perhaps if we just don't want it for k8s repos we can add a
test-infra specific config check for it.

On Wed, Jan 30, 2019 at 8:11 AM Steve Kuznetsov [e-mail]
wrote:

We can also just keep it around? It doesn't cost us any maintenance burden
AFAICT

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/11037#issuecomment-459003477,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4Bq6FeMve6OD-OWxV3vtbA4IBxENLjks5vIcRHgaJpZM4aZded
.

[nikhita]

Going to remove good-first-issue from here because the direction isn't completely clear.

/remove-good-first-issue

[spiffxp]

OK I'm fine not removing it for now, though I think its functionality can be folded in to something else down the line (possibly the elusive command framework in https://github.com/kubernetes/test-infra/pull/8131). This seems to be like the label plugin but with gating on team membership for certain label prefixes (in this case "status/*")

We shouldn't be cargo culting it around here, so probably a config cleanup + config check as @BenTheElder suggests.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[spiffxp]

/milestone clear

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.