Test-infra: Replace tot with snowflake IDs

Created on 28 Sep 2018  路  22Comments  路  Source: kubernetes/test-infra

ref https://github.com/kubernetes/test-infra/issues/9593#issuecomment-425325474

/area prow
cc @BenTheElder @cjwagner @spiffxp

aregubernator arekettle areprow aretestgrid prioritimportant-soon

All 22 comments

/area gubernator
Might have some impact here?

/area kettle
We would definitely want to revisit kettle's impl

/area testgrid
I don't know if this would impact testgrid at all, maybe during transition?

testgrid should be unimpacted unless we decide to go back, going back would be problematic. gubernator otoh reads latest-build.txt and would be fine.

/assign @fejta @BenTheElder
cc @Katharine to fix gubernator
cc @michelle192837 to fix testgrid and kettle

I think testgrid already works fine? not sure about kettle cc @spiffxp
Gubernator will need fixing or we'll need spyglass to be ready though

TestGrid's fine in its current implementation as long as the IDs monotonically increase. It'll need tweaks if not.

they're monotonic, just with gaps. testgrid is already handling some timestamp IDs so we should be good 馃憤
http://testgrid.k8s.io/conformance-cloud-provider-openstack#periodic-master

Made the required gubernator change in #9911. It's slow.

Gubernator already has fallback logic in case latest-build.txt doesn't exist, so it might instead be preferable to just ensure there is no latest-build.txt?

Gubernator changes are live, so that blocker is gone.

so probably just check kettle and then we can look at deleting the service

Looked into this briefly, we also need to set sequential: false as appropriate in kettle/buckets.yaml before we kill tot.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/remove-lifecycle stale

There are no known (to me) blockers on this. We just need to pick a time we don't expect to matter an awful lot if things are on fire. After we work through the merge backlog at the beginning of the 1.15 cycle maybe?

We'll also have to loop in contribex and maybe kubernetes-dev because the numbers will be large and ugly and that's a change.

I'm in favor of trying this out, and yes we should give kubernetes-dev@ a heads up. My only ask is that we wait until v1.14 goes out the door.

After 1.14 ships is my plan.

/woof

@stevekuznetsov: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/pony snowflake

@spiffxp: pony image

In response to this:

/pony snowflake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

We did it!

/pony cheering
/close

@Katharine: Closing this issue.

In response to this:

We did it!

/pony cheering
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Katharine: pony image

In response to this:

We did it!

/pony cheering
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Hi folks!
Currently we are having issue with perfdash - it doesn't work. https://github.com/kubernetes/perf-tests/issues/469
Assuming that you made changes to the other tools, can someone give hints on how to work with the new run id format? We are using k8s.io/contrib/test-utils/utils/utils.go for accessing the run logs.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

stevekuznetsov picture stevekuznetsov  路  3Comments

BenTheElder picture BenTheElder  路  4Comments

spzala picture spzala  路  4Comments

Aisuko picture Aisuko  路  3Comments

sjenning picture sjenning  路  4Comments