Test-infra: mkpj needs to support split job config

[BenTheElder]

/kind bug
/area prow
/assign @krzyzacy

[krzyzacy]

what does this mean?

[BenTheElder]

prow/cmd/mkpj needs to work with multiple job config files, right now it only has a --config-path= file to specify monolithic config.yaml

[krzyzacy]

IMO you pass in one config file for one job, unless we want a batch mode for mkpj

[BenTheElder]

@krzyzacy I suspect right now it would fail to load it :-)

func main() {
    o := gatherOptions()
    if err := o.Validate(); err != nil {
        logrus.Fatalf("Invalid options: %v", err)
    }

    conf, err := config.Load(o.configPath, "")
    if err != nil {
        logrus.WithError(err).Fatal("Error loading config.")
    }

[krzyzacy]

why? it should not.

[BenTheElder]

@krzyzacy if the job is in another file we won't load it... we only load the main prowConfig file right now. It won't parse ...?

In any case it should also support reading in all of the files so you don't have to hunt down the right file to retrigger a job with the new config :-)

[krzyzacy]

sure, I'll add another flag, basically for all the controllers.

[krzyzacy]

/joke

[k8s-ci-robot]

@krzyzacy: I wish I could clean mirrors for a living. It's just something I can see myself doing.

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[krzyzacy]

https://github.com/kubernetes/test-infra/blob/master/prow/cmd/mkpj/main.go#L62

looks like it's supported now