Test-infra: slackevents merge warnings whitelist should be locked by branch

Created on 16 Apr 2018 · 6Comments · Source: kubernetes/test-infra

we should be able to check the ref of the pushevent to match on the branch pushed to, and then update the config to restrict branch managers to their respective branches when whitelisting them.

cc @cjwagner

areprow help wanted

Source

BenTheElder

Most helpful comment

Relevant bits of code for someone looking at this:
https://github.com/kubernetes/test-infra/blob/master/prow/plugins/slackevents/slackevents.go
https://github.com/kubernetes/test-infra/blob/8d7d1e4ec835080bc2dbfd3ee3bd4f1a6342c6d4/prow/plugins/plugins.go#L374-L384
https://github.com/kubernetes/test-infra/blob/8d7d1e4ec835080bc2dbfd3ee3bd4f1a6342c6d4/prow/plugins.yaml#L104-L129

cblecker on 16 Apr 2018

👍2

All 6 comments

/area prow

cblecker on 16 Apr 2018

/help

cjwagner on 16 Apr 2018

@cjwagner:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.