We have a need to lock down some directories/files tighter than the global OWNERS list. We'll probably have more in the future. It would be nice to be able to do this with OWNERS. Inside Google, OWNERS files allow this with set noparent syntax. Possible YAML syntax might be
options:
parent_owners: false
reviewers:
- mml
approvers:
- mml
FWIW, the use case here is only allowing a couple of people from sig-architecture to approve changes in to the set of conformance tests. This is for https://github.com/cncf/k8s-conformance
This does look like an easy change to https://github.com/kubernetes/test-infra/blob/master/mungegithub/features/repo-updates.go
cc @BenTheElder
/assign cjwagner bentheelder
Changes should be made to Prow's equivalent of Mungegithub's repo-updates feature: https://github.com/kubernetes/test-infra/blob/master/prow/repoowners/repoowners.go
/area prow
@mml prow now supports:
options:
no_parent_owners: true
reviewers:
- mml
approvers:
- mml
Opened https://github.com/kubernetes/community/issues/1286 for us to doc this
Well that was fast. Is this live?
Unfortunately not, I jumped the gun on that :-(
The support is there but the plugin using it is pending in https://github.com/kubernetes/test-infra/pull/5115 which should be done soonish
Support exists, but it's only going to be run against test-infra initially (https://github.com/kubernetes/test-infra/pull/5115#issuecomment-340917718)
@cjwagner we should probably close this after it's deployed to cncf/k8s-conformance ?
Actually the directory we want to restrict is in kubernetes/kubernetes.
Is this live against k/k yet?
Not yet. Its ready to be rolled out to more repos though. I'd like to try the new plugin in a couple more repos before turning it on in k/k, but I'll start doing that today so that we can enable this in k/k next week.
Awesome, thanks @cjwagner
Where is this at? Looks like it's still ignored for, e.g. https://github.com/kubernetes/kubernetes/pull/54837
k/k is still handled by the munger, but the plugin has been enabled on every other kubernetes repo that uses the approved label so its ready to go to k/k.
I'll make a PR to enable the plugin on k/k, but lets wait until Monday to deploy it.
SGTM
Most helpful comment
Actually the directory we want to restrict is in kubernetes/kubernetes.