Prow looks at both a repos collaborators and those in the OWNERS file to determine ownership. Is there any tool that would let one audit a repo and diff who is in the OWNERS files vs who is a collaborator to look for any gaps? For example, to find someone listed in an OWNERS file who is not a collaborator.
I'm not aware of one. It probably shouldn't be very difficult to do using the GitHub APIs though. You might want to bring this up with sig-contribex.
Sounds like a useful tool to have. I think OWNERS are required to be collaborators but as people move between jobs/companies/projects, OWNERS can get stale.
The tools filter the OWNERS against the collaborators for, I believe, security purposes. Being able to do an audit would be useful for catching problems.
cc @php-coder
/area prow
FYI, I've written one. With a little cleanup and some tests I'll PR it to the test-infra repo.
/assign @mattfarina
any update on this?
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
/remove-lifecycle rotten
/reopen
@kargakis: you can't re-open an issue/PR unless you authored it or you are assigned to it.
In response to this:
/remove-lifecycle rotten
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
The linked PR has been aged out. I asked the author if they were going to pick it back up and they said it didn't seem like anyone wanted it. Is there any reason for this issue to remain open @kargakis ?
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
This would be nice, especially if we could get it automated in verify-owners or similar, so users get better feedback on why their OWNERS isn't working.
/remove-lifecycle rotten
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
/remove-lifecycle stale
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
/remove-lifecycle stale
On Fri, Apr 5, 2019 at 3:58 PM fejta-bot notifications@github.com wrote:
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta
https://github.com/fejta.
/lifecycle stale—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/5175#issuecomment-480227153,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APXA0Id3yb3FcDawkK45O_h9BTaPVR5hks5vdyVlgaJpZM4QGtkD
.
Created https://github.com/kubernetes/test-infra/pull/12297 to update the verify-owners plugin to ensure that all new users added to OWNERS and OWNERS_ALIASES files are org collaborators.
I'm happy to follow up on the original WIP PR https://github.com/kubernetes/test-infra/pull/6165, but wanted to double check if we still want to have this? I think it could be useful to audit old OWNERS files...but I'm not sure if this should live in test-infra or if this should be a one off tool?
cc @cblecker
/sig contributor-experience
/cc @mrbobbytables ^^
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
ref: https://github.com/kubernetes/community/issues/1808 since this is about auditing OWNERS files, and that's the umbrella issue I keep linking to as I find related issues
/remove-lifecycle stale
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Most helpful comment
FYI, I've written one. With a little cleanup and some tests I'll PR it to the test-infra repo.