Test-infra: Autoreload Prow secrets.

Created on 27 Sep 2017  Â·  14Comments  Â·  Source: kubernetes/test-infra

While debugging, I autogenerated a new oauth token for my Prow cluster. This invalidated the previous token (which was working). I added the new token to the Prow cluster secrets, but hook jobs were getting Bad Credentials errors when trying to run presubmit on PRs.

Bouncing the Hook and Plank jobs fixed the issue.

areprow help wanted kinfeature

Most helpful comment

Heh, so it also reopened it for you while simulataneously commenting that you can't do that :|
@cjwagner

Nah, @kargakis deleted some other comments.
I agree that the ACLs for /reopen should be looser though.

All 14 comments

It's certainly possible. We can make the GitHub client regularly watch the secret file like the config agent. This might also tidy up some repeated secret reading code.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

/lifecycle frozen

/remove-lifecycle frozen
/remove-lifecycle stale

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

/remove-lifecycle stale

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

/remove-lifecycle rotten
/assign
/reopen

On Sun, Jun 24, 2018, 21:49 k8s-ci-robot notifications@github.com wrote:

Closed #4761 https://github.com/kubernetes/test-infra/issues/4761.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/4761#event-1697724216,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADuFfxgiy7MwoSDLp_MabROrv9Sin5Pcks5t_-1MgaJpZM4PlBsG
.

@kargakis: you can't re-open an issue/PR unless you authored it or you are assigned to it.

In response to this:

/remove-lifecycle rotten
/assign
/reopen

On Sun, Jun 24, 2018, 21:49 k8s-ci-robot notifications@github.com wrote:

Closed #4761 https://github.com/kubernetes/test-infra/issues/4761.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/4761#event-1697724216,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADuFfxgiy7MwoSDLp_MabROrv9Sin5Pcks5t_-1MgaJpZM4PlBsG
.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Heh, so it also reopened it for you while simulataneously commenting that you can't do that :|
@cjwagner

Heh, so it also reopened it for you while simulataneously commenting that you can't do that :|
@cjwagner

Nah, @kargakis deleted some other comments.
I agree that the ACLs for /reopen should be looser though.

There is a different PR/issue where I managed to reopen on a single comment but I wasn't lucky enough on this one :(

@droslean

Was this page helpful?
0 / 5 - 0 ratings

Related issues

stevekuznetsov picture stevekuznetsov  Â·  4Comments

stevekuznetsov picture stevekuznetsov  Â·  3Comments

BenTheElder picture BenTheElder  Â·  4Comments

benmoss picture benmoss  Â·  3Comments

lavalamp picture lavalamp  Â·  3Comments