Test-infra: SQ constantly comments approval-handler messages every loop

[yutongz]

I am deploying submit-queue for istio, everything looks fine except when I enable approval-handler, sq keeps commenting with the same message about approval notification pr
foxish pointed me to this issue, so I tried to replace the botName with our bot except test files, but still get the same problem.
By the way, I can't build mungegithub binary with "make mungegithub" so I use bazel build to get binary and build docker image, I guess it doesn't affect everything but just want you guys know.
Any idea?

[yutongz]

@foxish @apelisse

[foxish]

cc/ @cjwagner

[cjwagner]

The bot names should definitely be parameterized. Did you change https://github.com/kubernetes/test-infra/blob/master/mungegithub/mungers/matchers/comment/interactions.go#L67?

[kargakis]

The bot names should definitely be parameterized. Did you change https://github.com/kubernetes/test-infra/blob/master/mungegithub/mungers/matchers/comment/interactions.go#L67?

Hrm, can we move those into the munger config?

[kargakis]

@stevekuznetsov fyi

[yutongz]

OK, I think I figured out how to teach mungegithub recognize our bot name. I am going to create a pr to make bot name configurable.

[stevekuznetsov]

@yutongz we've got a PR in the works as well -- if you have not yet started, it may save you time. We will try to deliver it soon

[yutongz]

@stevekuznetsov that will be awesome, thanks!

[kargakis]

/assign stevekuznetsov

[k8s-ci-robot]

@kargakis: GitHub didn't allow me to assign the following users: stevekuznetsov.

Note that only kubernetes members can be assigned.

In response to this:

/assign stevekuznetsov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kargakis]

This is still an issue ...

[fejta]

/assign @cjwagner @BenTheElder

[stevekuznetsov]

@kargakis were you able to determine why?

[kargakis]

Haven't looked yet, no. I want to setup a test cluster but won't get to it before Monday morning.

[stevekuznetsov]

I think these also need to be configurable

[stevekuznetsov]

There's a couple of those:

mungegithub/mungers/matchers/comment/interactions.go:67:    return AuthorLogin("k8s-merge-robot")
mungegithub/mungers/matchers/event/event.go:110:    return Actor("k8s-merge-robot")
mungegithub/mungers/matchers/interactions.go:96:    return AuthorLogin("k8s-merge-robot")

[stevekuznetsov]

Hmm, it looks like there are two very different ways to match comments and my PR only addressed one of them. I'll work on that.