Test-infra: Standardize bot commands

Created on 22 May 2017  路  9Comments  路  Source: kubernetes/test-infra

The k8s-bot commands are not consistent with other bot commands. A new set of commands below may be more coherent:
(1) @k8s-bot test this -> /test this
(2) @k8s-bot ok to test -> /ok to test
(3) @k8s-bot tell me a joke -> /tell me a joke

We may also can have a more abridged version of commands:
(1) @k8s-bot test this -> /test
(2) @k8s-bot ok to test -> /ok
(3) @k8s-bot tell me a joke -> /joke

Most helpful comment

to keep consistency with current commands, the very first part of the command after the / should be one "word", with dashes instead of white spaces.

so /test or /ok-to-test make sense.. but /ok to test and /test this probably don't.

I'd also suggest that if it makes sense to re-word the commands, we take this opportunity to do so. the @k8s-bot format was in the tone of you're talking to the bot and telling it to do something. if we're formatting these into slash commands, then something like:

  • /test = @k8s-bot test this
  • /test ok = @k8s-bot ok to test
  • /test pull-kubernetes-verify = @k8s-bot pull-kubernetes-verify test this

All 9 comments

@fejta @spxtr
/cc @grodrigues3

Please include all of the @k8s botcommands when you refactor.

to keep consistency with current commands, the very first part of the command after the / should be one "word", with dashes instead of white spaces.

so /test or /ok-to-test make sense.. but /ok to test and /test this probably don't.

I'd also suggest that if it makes sense to re-word the commands, we take this opportunity to do so. the @k8s-bot format was in the tone of you're talking to the bot and telling it to do something. if we're formatting these into slash commands, then something like:

  • /test = @k8s-bot test this
  • /test ok = @k8s-bot ok to test
  • /test pull-kubernetes-verify = @k8s-bot pull-kubernetes-verify test this

@kubernetes/sig-contributor-experience-misc

@cblecker: These labels do not exist in this repository: sig/contributor-experience.

In response to this:

@kubernetes/sig-contributor-experience-misc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I agree with @cblecker except instead of /test ok I prefer /ok-to-test or just /ok.

i think /ok is good. :)

/ok is good because it's short. But it's also so short that it's not very explicit, and it is a command that we may want to reserve for later use.

I vote /ok-to-test FWIW

I have started to work at it, and found @k8s-bot test this command is used only in config.yaml file (and test files). Correct me if i am wrong.

If standardizing the bot commands aims to give a better experience for contributors, i wonder whether we need to change the @k8s-bot test this command.

Was this page helpful?
0 / 5 - 0 ratings