Test-infra: Time zone in testgrid is ambiguous

[kargakis]

It's not clear to me that testgrid uses Pacific time. Ideally, the time zone should be configurable.

[krzyzacy]

or use local time?

[kargakis]

Yes

[krzyzacy]

/assign @michelle192837

[spiffxp]

is this still locked to pacific time? I'm in pacific so I can't tell...

[michelle192837]

I believe it is, yes.

[spiffxp]

Using my current east coast superpowers I can confirm that yes, it's still locked to pacific time

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[spiffxp]

/remove-lifecycle stale
@fejta @michelle192837 is this something a contributor outside of google can accomplish? otherwise I'm not sure the help wanted label belongs here

[michelle192837]

Not at the moment, unless someone wants to implement it as a Chrome extension that changes all the time-related column headers (which I'm going to guess, is a no).

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[kargakis]

/remove-lifecycle stale

[michelle192837]

I can update the column header tooltip to display what the timezone is, if that's a good bandaid. (It will always be pacific until configurable timezones are a thing, but at least it'll be displayed).

[michelle192837]

Okay, I'm going to look into 1) updating that tooltip to say PST/PDT (as noted above), and per a suggestion from @neolit123, 2) look into a frontend option to display times according to the user's brower's timezone. (Probably as a toggle, at least to start).

ETA: Starting next week because I'm out until Tuesday.

[neolit123]

i think a toggle should be the ideal option here - e.g. "show local times"
and the non-local times should be UTC, which can be used in case folks need to talk about a certain test across different TZs.

[michelle192837]

Bleh, it's been a while. Some stuff (like a cold and some other work) hit, but I want to get a look at this by Friday if it's an easy-enough change.

[jdunphy]

Even simply listing the timezone next to the stamps would be helpful for context.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[neolit123]

/lifecycle frozen

[krzyzacy]

/unassign
cc @tony-yang who might be interested

[fejta]

GST

[tony-yang]

At the moment, I think the default time format will still be displayed in PST due to historical reason. (Update: just clarified with other folks, storage is probably in UTC, default rendering in PST) I will be looking into adding the timezone label to the header/tooltip and also displaying local time based on location, as per @michelle192837 suggested above.

[tony-yang]

The timezone label is now live for Testgrid. Time displayed on the UI should now have the label PDT. Coming up next is the ability to choose the timezone (between local time and Pacific Time) using a toggle button on the UI as well as a setting in the config file. The default timezone label will change to local time, with the ability to opt-out to Pacific Time.

[neolit123]

@tony-yang
thanks for working on this.

i think i see a new problem related to the commit SHA:

https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-all#kubeadm-gce-master

[michelle192837]

That tooltip is hardcoded and I think needs to be swapped out (for Build ID?)

[tony-yang]

@neolit123 Thanks for bringing that issue up. We have also noticed that problem on many of our views. As Michelle commented, we are still deciding on how to proceed with the overflow content as well as the incorrect tooltip. We are definitely tracking this issue and will keep everyone posted. Cheers.

[tony-yang]

The timezone toggle switch (located beside the Graph button) and an option in config named display_local_time are now live. By default local time is turned on. Users can either switch back to PST during the session by clicking the toggle switch, or make a permanent switch using the config by setting the display_local_time attribute to true or false.

[matthyx]

@tony-yang so this issue can be closed?

[tony-yang]

@matthyx Yes, this issue can be closed. Unfortunately I don't have the permission to do so. I'll check with Michelle, or anyone with the right permission, please feel free to close this issue. Thanks.

[michelle192837]

/close

Thanks Tony! :D

[k8s-ci-robot]

@michelle192837: Closing this issue.

In response to this:

/close

Thanks Tony! :D

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.