Terraforming-mars: Feature Request: Sounds

Created on 30 May 2020  ·  10Comments  ·  Source: bafolts/terraforming-mars

Play a sound when certain events occur. Examples:

  • "It's your turn!" notification
  • Placing a city / greenery / ocean / special tile
  • Temperature / Venus is raised
  • Card played
  • Blue card action taken
  • Colony built / traded with colony
  • Delegate sent to party
  • Generation ended
  • Game ended (win / loss)
enhancement

Most helpful comment

In my own experience, the most crucial of all the sounds seems to be when it is your turn in a multiplayer game

All 10 comments

That a great idea , hope to see it soon

In my own experience, the most crucial of all the sounds seems to be when it is your turn in a multiplayer game

image
image
image
The HTML5 WebAudioAPIs are wonderful, not required any *.mp3 or *.wav , avoid taking up too much network traffic

@jijiqw Do you want to try adding one sound as a proof of concept?

Looks like this is partially implemented. I personally would like a small ding with every log message. Is anyone looking at this?

@kberg We can close this issue for now. I like having more sounds too (e.g. different types of tile placement sounds) but it's a bigger task to add those as the client is currently stateless

How does statefulness play into this? Maybe it's because I'm interested in
a specific subset of changse that I don't see why that matters.

>

@kberg Possibly. It depends on which sound(s) you want to add and where. Feel free to take a stab at it if you have a specific sound and use case in mind. We can probably keep all the sounds in one file and under the same "Enable sounds" toggle for now since there will probably be at most 2-3 of them 👍

@nwai90 Why not add event listeners to relevant DOM changes, which can then trigger sounds?

Based on how people voted in #dev-topics, starting with adding these sounds seems wise:

TR Increases

  • ↑ Oceans
  • ↑ Oxygen
  • ↑ Temp
  • ↑ Venus

Placing Tiles

  • Forest (overrides oxygen sound)
  • Cities
  • Brown Tiles
  • Colony Built

Gaining VPs

  • Milestone bought
  • Award funded

We can always add more later.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Carcassonner picture Carcassonner  ·  5Comments

sienmich picture sienmich  ·  5Comments

cdekker picture cdekker  ·  3Comments

galfridus picture galfridus  ·  5Comments

dabewi picture dabewi  ·  5Comments