Terraforming-mars: Feature request: Actions log to show the card preview for card-related actions(played/activated)

Created on 20 Mar 2020  路  12Comments  路  Source: bafolts/terraforming-mars

log
In the log:

  • Player name to be displayed in the player's color
  • Card name to be displayed as it is in the card (matching colors and fonts)
  • When the card name is clicked, the preview div is displayed (X dismisses it)

Notes:
I don't know the cards' names, even after 1000+ games, I know only a handful.
When I played 1vs1 I kept the Cards List page open in another tab and was copy/past -ing there every card name my opponent played/activated.

enhancement

Most helpful comment

Started working on this (at least the coloring part, not yet the preview div) tonight and already made some progress. Would be great if someone could assign me to this.

Early Screenshot:
colors

I had to put the player names on a lighter background as well, otherwise it would be impossible to see the black player.

All 12 comments

It is a good idea! We will implement it, but not right now

Started working on this (at least the coloring part, not yet the preview div) tonight and already made some progress. Would be great if someone could assign me to this.

Early Screenshot:
colors

I had to put the player names on a lighter background as well, otherwise it would be impossible to see the black player.

@gomfunkel
Is that an easy option to do as well: (generations breakdown)
Untitled

And also, is it possible to fix a bug in this pr as well:
"End Turn" action does not log anything.
E.g. "Player 1 turn ended"

Great ideas, @ssimeonoff! Should be possible as the log is just a list of strings as it is now. Will see what I can do.

I have implemented the following ideas from this issue and submitted pull request #446.

  • Using player colors
  • Using card type colors and font
  • Added log message when ending turn
  • Added log message on new generation

Displaying the cards on click in the logs is still to be done.

Here鈥檚 what the log now looks like:
Screenshot 2020-03-24 at 10 18 44

I have done some test and I have this result:
Capture d鈥檈虂cran 2020-03-27 a虁 19 57 57

Will it be okay for everyone?

@pierrehilbert I had something a bit different in mind for the UI but if yours is working, I鈥榤 totally fine with it. I didn鈥榯 start implementing the functionality yet, so go ahead.

It's merged!

Thank you, @pierrehilbert! This is very helpful. I found some issues with this approach, though:

  • The whole log message is linked to a card, not just the card itself
  • Log messages not containing played cards open a blank card frame when clicked
  • Log message containing more than one card (i.e. when using _Robotic Workforce_) only open one of the cards when clicked
  • Clicking a log message multiple times always opens another card

Thinking about it a bit more we probably need a component for <log-card/> to allow proper interaction. I will gladly have another shot at this but am not sure when I will be able to do so.

I corrected the blank part and the double display of the same cards.
For the log part, I think it could be great to indicate more informations.
Some examples:

  • When trading with a colony, display how many resources did the player get.
  • When using a blue card and there is multiple choice, display which one have been chosen.

Is this issue still relevant ?

I think no

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Carcassonner picture Carcassonner  路  5Comments

duckmammal picture duckmammal  路  5Comments

alrusdi picture alrusdi  路  5Comments

dabewi picture dabewi  路  6Comments

ATiredVegan picture ATiredVegan  路  5Comments