Terraform-provider-libvirt: Crowd Fund some updates to terraform-provider-libvirt

[BruceBushby]

Anybody else interested in "crowd funding" some updates to this provider ? I'll kick off the pot with $100.00

I need

1. Clean up to build with latest terraform and other libraries (libvirt-go-xml)
2. Add ability to use command line or environment variables

I tried building with "latest everything" however it looks like the definitions for "libvirt-go-xml" may have changed:

ok 12:35 root@dc00 ~/go/src/github.com/terraform-provider-libvirt

make build

bash travis/run-gofmt
==> Checking that code complies with gofmt requirements...
* checking pkg libvirt with gofmt
pkg libvirt has no lint gofmt errors!

* running gofmt on main.go
==> go fmt OK !!! *
golint ./libvirt
go vet .
go build

github.com/terraform-provider-libvirt/libvirt

libvirt/disk_def.go:14:7: unknown field 'Type' in struct literal of type libvirtxml.DomainDisk
libvirt/domain.go:199:24: cannot use networkInterface.Source.Network (type libvirtxml.DomainInterfaceSourceNetwork) as type string in append
libvirt/domain_def.go:13:7: unknown field 'Type' in struct literal of type libvirtxml.DomainFilesystem
libvirt/domain_def.go:40:10: unknown field 'Type' in struct literal of type libvirtxml.DomainGraphic
libvirt/domain_def.go:41:14: unknown field 'AutoPort' in struct literal of type libvirtxml.DomainGraphic
libvirt/domain_def.go:46:10: unknown field 'Type' in struct literal of type libvirtxml.DomainChannel
libvirt/domain_def.go:48:11: unknown field 'Type' in struct literal of type libvirtxml.DomainChannelTarget
libvirt/domain_def.go:49:11: unknown field 'Name' in struct literal of type libvirtxml.DomainChannelTarget
libvirt/domain_def.go:57:12: unknown field 'Model' in struct literal of type libvirtxml.DomainRNGBackend
libvirt/resource_libvirt_domain.go:668:50: domainDef.OS.KernelArgs undefined (type *libvirtxml.DomainOS has no field or method KernelArgs)
libvirt/resource_libvirt_domain.go:668:50: too many errors
make: ** [Makefile:4: build] Error 2

fail 12:35 root@dc00 ~/go/src/github.com/terraform-provider-libvirt
#

[kskewes]

I'll do $50. It's been useful for labbing.
Pretty keen on this one #290

[biox]

Agreed, I'd also throw money in this pot (and help with some of the more simple work)

[dmacvicar]

Why not post it in some system like https://www.bountysource.com and then I can link them from the README?

[brejoc]

Alright, this issue is now referenced from BountySource and I've started with $20.

Update: I think it should be possible to split the bounty if more than one is working on the issue. At least I've seen this some years ago.

[kskewes]

Thanks for starting it. Chipped in 50 for #290.

[BruceBushby]

Thanks for starting, added $100.00

On Tue, Jul 10, 2018 at 12:46 PM, Jochen Breuer [e-mail]
wrote:

Alright, this issue is now referenced from BountySource
https://www.bountysource.com/issues/57535849-crowd-fund-some-updates-to-terraform-provider-libvirt
and I've started with $20.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dmacvicar/terraform-provider-libvirt/issues/295#issuecomment-403794145,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXyto12f8T36NqYkVHELoyBdhiJ7uSLks5uFJP4gaJpZM4TiWFG
.

[dmacvicar]

Can you explain more about:

Add ability to use command line or environment variables

[dmacvicar]

I have splited the dependencies part to https://github.com/dmacvicar/terraform-provider-libvirt/issues/320
Can anyone please:

• Update the bounty-source links
• Open an issue for the environment variables part, which is not very clear what is desired.

I would prefer to close this issue as it mixes different things.

[MalloZup]

thank you all :heart: and @brejoc for seting that up

[dmacvicar]

I claim the first part of the bounty through https://github.com/dmacvicar/terraform-provider-libvirt/pull/322
(minor some decisions that need to be made to merge it, and the missing explanations about env variables)

[kskewes]

Thanks, can't figure out how to change contributed bounty to be against #290 instead and it looks claimed. :)

[BruceBushby]

Apologies for my delay in clarifying requirements, I have since moved on so
having to scratch my head to remember what motivated the idea in the first
place.

From my side, the two areas I was hoping for improvement were

1. Environment variables expanded correctly
2. Full implementation of libvirt-go library, for example the ability to
   define the mac address in terraform and other libvirt-go functions that
   were not present.

Bruce

On Wed, Jul 11, 2018 at 7:27 PM, kskewes [e-mail] wrote:

Thanks, can't figure out how to change contributed bounty to be against

290 https://github.com/dmacvicar/terraform-provider-libvirt/issues/290

instead and it looks claimed. :)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dmacvicar/terraform-provider-libvirt/issues/295#issuecomment-404266635,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXyttKEP708mZRzm_aSE_u00aj-buEAks5uFkOtgaJpZM4TiWFG
.