Terraform-provider-google: Support for google_container_cluster istio addon

[bluemalkin]

Now that istio is released in beta https://cloud.google.com/blog/products/containers-kubernetes/accelerate-your-app-delivery-with-kubernetes-and-istio-on-gke

And that it can be added as an addon:

We should add it as an add-on to the google beta provider: for example:

resource "google_container_cluster" "foo" {
  name = "foo"
[  ....]
  addons_config {
    istio {
      disabled = false
    }
  }
}

[danawillow]

Hey @bluemalkin, in the future would you mind filling out the template and leaving the commented lines in? They help hashibot label our issues :) Thanks!

[agadelshin]

HI. I'd like to add this feature. Can I do this?

[danawillow]

Sure, I'll mark this as assigned!

[agadelshin]

@danawillow I've found that beta features (like cluster_autoscaling) were moved to terraform-provider-google-beta. Should I create PR to beta repo instead?

[danawillow]

Yup, that would be helpful, thanks!

[brettcurtis]

So is this in the beta provider now?

[agadelshin]

@brettcurtis yep

[agadelshin]

I guess it can be closed now due to https://github.com/terraform-providers/terraform-provider-google-beta/pull/280

[rsalmond]

Hey @pondohva I'm sorry it's not clear to me from that issue what decision has been made. Can this issue be closed because the istio feature has been merged to master or because a decision has been made to revert it?

[agadelshin]

@rsalmond it has been merged to master of beta provider, because istio is beta feature.

[rsalmond]

:+1: thanks!

[rileykarson]

Closed with https://github.com/GoogleCloudPlatform/magic-modules/pull/1101- this should appear in the google-beta provider starting with version 2.0.0.

[hashibot[bot]]

I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!