Terraform-provider-aws: aws_cloud_watch_logs resource appends wildcard to ARN in output

Created on 30 Jul 2020  ·  4Comments  ·  Source: hashicorp/terraform-provider-aws

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.12.24

  • provider.archive v1.3.0
  • provider.aws v2.69.0

Affected Resource(s)

  • resource: aws_cloudwatch_log_group
  • data: aws_cloudwatch_log_group

Terraform Configuration Files

resource "aws_cloudwatch_log_group" "log-group" {
  name = "my-log-group"
}

data "aws_cloudwatch_log_group" "log-group" {
  name = "my-log-group"
}

output "log-group-arn-resource" {
  value = aws_cloudwatch_log_group.log-group.arn
}

output "log-group-arn-data" {
  value = data.aws_cloudwatch_log_group.log-group.arn
}

Debug Output

Panic Output

Expected Behavior

Expect output to be:
arn:aws:logs:{region}:xxxxxxxxxxxx:log-group:my-log-group

Actual Behavior


arn:aws:logs:{region}:xxxxxxxxxxxx:log-group:my-log-group:*

Steps to Reproduce

  1. terraform apply

Important Factoids


I would expect it to leave off the :* so it can be used in other resources, if a :* is needed for something, then the dev can know to add it instead of having to strip it off when it's in the way.

For example, I am trying to use it in an IAM role where :* is not the appropriate format.
https://docs.amazonaws.cn/en_us/IAM/latest/UserGuide/list_amazoncloudwatchlogs.html

arn:${Partition}:logs:${Region}:${Account}:log-group:${LogGroupName}
arn:${Partition}:logs:${Region}:${Account}:log-group:${LogGroupName}:log-stream:${LogStreamName}

To ensure the fix is backwards compatible, adding a new output with the strict arn would work.

References

  • #0000
needs-triage serviccloudwatch serviccloudwatchlogs

Most helpful comment

Hi @GoldFlsh 👋 Thank you for submitting this and its indeed frustrating behavior. Prior versions of the Terraform AWS Provider just passthrough the ARN value from the CloudWatch Logs API, which includes the :*. Version 3 of the Terraform AWS Provider will automatically trim this suffix from the API response. Please see the following for further tracking of this change, which should be happening shortly:

All 4 comments

Hi @GoldFlsh 👋 Thank you for submitting this and its indeed frustrating behavior. Prior versions of the Terraform AWS Provider just passthrough the ARN value from the CloudWatch Logs API, which includes the :*. Version 3 of the Terraform AWS Provider will automatically trim this suffix from the API response. Please see the following for further tracking of this change, which should be happening shortly:

Great to hear, thank you for fixing this @bflad !

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

Was this page helpful?
0 / 5 - 0 ratings