Terraform-provider-aws: aws_lb needs to support setting the drop_invalid_header_fields setting

[fszymanskivertex]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Based on a change in default behavior to the AWS load balancers described at https://docs.aws.amazon.com/elasticloadbalancing/latest/application/application-load-balancers.html, the routing.http.drop_invalid_header_fields.enabled defaults to true for load balancers starting on November 11, 2019.

Due to the AWS implementation, headers that should be valid such as "access_token" are being dropped. This is discussed on the official forums at https://forums.aws.amazon.com/thread.jspa?messageID=923165&#923165

In order to allow load balancers to be created in the previous behavior, the aws_lb resource needs to be able to set the drop_invalid_header_fields setting.

New or Affected Resource(s)

• aws_lb

References

• https://docs.aws.amazon.com/elasticloadbalancing/latest/application/application-load-balancers.html
• https://forums.aws.amazon.com/thread.jspa?messageID=923165&#923165

[bionicles]

had a hell of a time getting LB -> lambda to work this week, it just hung and wouldn't forward to the lambda, would love to see better LB, Lambda docs / support in Terraform because ALB is theoretically easier/better/cheaper than API Gateway for Lambda, and it integrates nicely with Cloudfront

[jonDowdle]

AWS changed the default for this field. The default is now false.

[kireledan]

I'm going to work on this today. Should have PR up by EOD or morning.

[bwalding]

The impact of this LB setting not being set to true just hit the news after a Slack security issue - https://hackerone.com/reports/737140 - https://news.ycombinator.com/item?id=22567937

[bflad]

Support for the drop_invalid_header_fields argument for the aws_lb resource has been merged and will release with version 2.54.0 of the Terraform AWS Provider, on Thursday. Thanks to @kireledan for the implementation. 👍

[hashibot[bot]]

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[hashibot[bot]]

I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!