Terraform-provider-aws: Add support for ECR image scanning

[tomelliff]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

ECR repos now support image scanning. This support is in the v1.25.20 SDK.

New or Affected Resource(s)

• aws_ecr_repository resource and data source

Potential Terraform Configuration

resource "aws_ecr_repository" "foo" {
  name = "bar"

  scan_on_push = true
}

References

https://aws.amazon.com/about-aws/whats-new/2019/10/announcing-image-scanning-for-amazon-ecr/

[ewbankkit]

Requires AWS SDK v1.25.20:

• https://github.com/terraform-providers/terraform-provider-aws/pull/10476

[sergei-ivanov]

I already have a working implementation for that on my branch. Only need to update the tests and the docs, and a PR will be ready, as soon as the latest AWS SDK is merged into master.

[bflad]

Just merged in AWS Go SDK v1.25.21, hope this helps.

[bflad]

Support for the below has been merged and will release with version 2.34.0 of the Terraform AWS Provider, tomorrow. Thanks to @sergei-ivanov for the quick implementation 👍

resource "aws_ecr_repository" "example" {
  # ... other configuration

  image_scanning_configuration {
    scan_on_push = true # or false :)
  }
}

[bflad]

This has been released in version 2.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[hashibot[bot]]

I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!