Terraform-provider-aws: feature(sagemaker notebook): Add Git Repository Support

[omarsamad-plutoflume]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS SageMaker has an ability to associate git repositories with the sagemaker notebook, can this be added to Terraform please?

Resources

aws_sagemaker_notebook_instance

References

https://docs.aws.amazon.com/sagemaker/latest/dg/nbi-git-repo.html
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sagemaker-notebookinstance.html#cfn-sagemaker-notebookinstance-additionalcoderepositories

[mwarkentin]

This can only be set on create (as far as I can tell) so the only way to set this up and manage it in terraform is to add the instance manually and then import it back into terraform. This is a bit crappy.

[xmj]

@mwarkentin Turns out you can change the setting and attach a repository when the Notebook Instance is stopped.

[presich]

What about SageMaker Git Repository entry itself? Do you maybe know if separate ticket has been created already?
Or the scope of that ticket should be increased maybe?

[ewbankkit]

Related:

• https://github.com/terraform-providers/terraform-provider-aws/issues/13817

[hashibot[bot]]

This has been released in version 3.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[hashibot[bot]]

I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!