Terraform-provider-aws: Support tags on aws_spot_fleet_request

[emman27]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

As mentioned. As of now, tags can only be attached to the EC2 instances spun up but not the request itself.

Also see https://github.com/terraform-providers/terraform-provider-aws/pull/2042#issuecomment-402967969

New or Affected Resource(s)

• aws_spot_fleet_request

Potential Terraform Configuration

resource "aws_spot_fleet_request" "req" {
  #... other configurations
  tags = {
        Name = "${var.name}"
    }
}

References

0000

[jkburges]

Is it even possible to tag a spot fleet request itself in AWS?

I can't see anything about it in any doc or APIs (so I think it may be a limitation of AWS rather than this terraform provider).

[electroly]

It is now: https://aws.amazon.com/about-aws/whats-new/2020/02/amazon-ec2-now-supports-tagging-ec2-spot-fleet-requests/

[DrFaust92]

addressed in #12295

[bflad]

Support for tagging Spot Fleet Requests has been merged and will release with version 2.57.0 of the Terraform AWS Provider, later today. Thanks to @DrFaust92 for the implementation. 👍

[hashibot[bot]]

This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[hashibot[bot]]

I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!