Terraform-provider-aws: RDS create from snapshot results in "InvalidParameterValue: The parameter ResourceName must be provided and must not be blank." error

[scottmoomaw]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

0.11.7

Affected Resource(s)

• aws_db_instance

Expected Behavior

RDS instance created from snapshot

Actual Behavior

• aws_db_instance.your_name_here: 1 error(s) occurred:
• aws_db_instance.your_name_here: InvalidParameterValue: The parameter ResourceName must be provided and must not be blank.
  status code: 400, request id: 0c2c6a32-ae88-434e-bc5a-7a6242f6bee7
  

  Steps to Reproduce

1. Upgrade aws-provider to 1.29.0
2. terraform apply

Important Factoids

There is a defect in version 1.29.0 of the aws-provider that causes failure of RDS creation becasue of error copying tags. The 1.29.0 version attempts to use an empty 'ResourceName=' value in a query. This behavior does not occur if you lock the aws-provider to version 1.28.0.

• #0000

[tinyzimmer]

This happened to me on testing my RDS module against the newest provider version. The database instances were created, but the module ultimately failed out with the same error posted above.

Reverting to provider 1.28 solves the issue for me as well.

[fantomc0der]

I just bumped into this issue a minute ago in Terraform v0.10.8 with AWS Provider ~> 1.2. I have an existing RDS instance in Terraform that's been working fine for a while and attempted adding a property for "snapshot_identifier" which points to the ARN of the shared snapshot with the account. In order to test it, I started to deploy a fresh RDS instance from its root module after verifying the planning looked good (all adds, no errors).

It seemed like it was working as it remained processing for around 20min until it errored on "aws_db_instance.primary: InvalidParameterValue: The parameter ResourceName must be provided and must not be blank". The database still exists in RDS so it did create it - but haven't been able to verify what the data differences from its current state and intended snapshot look like yet.

[bflad]

Hi folks 👋 Sorry for this regression. I believe I know the cause and fix for this issue. The fix will definitely make it into the version 1.30.0 release of the AWS provider.

More importantly though, it looks like we are missing some acceptance testing surrounding the usage of snapshot_identifier with aws_db_instance. 😅 I am working on that now so we can definitely be sure this regression is fixed as well as in the future.

[fantomc0der]

Thanks for the quick response. Pinned my AWS Provider to 1.28.0 and worked as expected.

[bflad]

Fix verified and submitted: #5370

[bflad]

The fix for this has been merged into master and will release with version 1.30.0 of the AWS provider, likely on Wednesday. 👍

[bflad]

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[myoung34]

This is unfixed in 1.30 per #5450

[hashibot[bot]]

I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!