Terraform-provider-aws: Support Neptune

[atsushi-ishibashi]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

• aws_neptune_cluster
• aws_neptune_cluster_instance
• aws_neptune_subnet_group
• aws_neptune_parameter_group
• aws_neptune_cluster_parameter_group
• aws_neptune_event_subscription

Potential Terraform Configuration

resource "aws_neptune_cluster" "example" {
  cluster_identifier = "example"
  engine = "neptune"
  engine_version = "1.0.1"
  cluster_parameter_group_name = "${aws_neptune_cluster_parameter_group.example.name}"
  subnet_group_name = "${aws_neptune_subnet_group.example.name}"
  database_name = "database"
  master_username = "user"
  master_password = "password"
  ...

}

resource "aws_neptune_cluster_instance" "example" {
  identifier = "example"
  cluster_identifier = "${aws_neptune_cluster.example.id}"
  engine = "neptune"
  instance_class = "db.m4.large"
  ...

}

resource "aws_neptune_subnet_group" "example" {
  name = "example"
  description = "example description"
  subnet_ids = ["${aws_subnet.frontend.id}", "${aws_subnet.backend.id}"]
}

resource "aws_neptune_parameter_group" "example" {
  name = "example"
  family = "example"
  description = "example description"
}

resource "aws_neptune_cluster_parameter_group" "example" {
  name = "example"
  family = "example"
  description = "example description"
}

resource "aws_neptune_event_subscription" "example" {
  name = "example"
  sns_topic = "${aws_sns_topic.example.arn}"
  source_type = "db-instance"
  source_ids = ["${aws_neptune_cluster_instance.example.id}"]
  event_categories = [
    "creation",
    "failover",
    ...
  ]
}

Order

1. aws_neptune_parameter_group,aws_neptune_cluster_parameter_group,aws_neptune_subnet_group
2. aws_neptune_cluster
3. aws_neptune_cluster_instance
4. aws_neptune_event_subscription

References

[dav009]

opened PR for aws_neptune_parameter_group https://github.com/terraform-providers/terraform-provider-aws/pull/4724

[saravanan30erd]

@atsushi-ishibashi @dav009 I would like to work on aws_neptune_subnet_group, anyone working on this?

[atsushi-ishibashi]

@saravanan30erd I'm not👍

[dav009]

@saravanan30erd go for it 👍.
I will address the requested changes in the open PR soon 🙇

[saravanan30erd]

@atsushi-ishibashi @bflad It looks like both RDS and Neptune using same resource DB Subnet Group for subnet groups, so I think we can use the same resource aws_db_subnet_group with just updating document, any thoughts?

[bflad]

@saravanan30erd each service requires its own connection/endpoint and resource handling will likely vary between the two. Definitely create separate resources even if they look very similar.

[saravanan30erd]

@atsushi-ishibashi @dav009 I am working on aws_neptune_cluster_parameter_group

[bflad]

For those following along:

• aws_neptune_parameter_group resource: released in version 1.23.0 (enhanced with arn and tags in 1.24.0)
• aws_neptune_cluster_parameter_group resource: released in version 1.24.0
• aws_neptune_subnet_group resource: released in version 1.24.0

[saravanan30erd]

@dav009 I am working on aws_neptune_cluster

[angelinatquach]

@saravanan30erd do you have an expected completion date? Great work so far btw! Really appreciating the rapid development.

[saravanan30erd]

@angelinatquach I am expecting to finish this resource before next release.

[austinkelleher]

We are using Neptune too and really looking forward to seeing this implemented. Thanks for your work on this @saravanan30erd!

[saravanan30erd]

@bflad still two resources are remaining aws_neptune_cluster_instance and aws_neptune_event_subscription, I am working on aws_neptune_cluster_instance.

[bflad]

I'll be picking up aws_neptune_event_subscription this week. 👍

[saravanan30erd]

@bflad I already started and on the half way :)-

[bflad]

@saravanan30erd even better! 😄

[bflad]

As of version 1.31.0 of the AWS provider, releasing shortly, all the above mentioned resources have been implemented. 🎉 For future bug reports and feature requests, please submit separate issues so we have a clear definition of done. Thanks!

[hashibot[bot]]

I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!