Please expand the aws_acm_certificate
resource to support the ability to import an existing in-hand certificate, a la https://docs.aws.amazon.com/sdk-for-go/api/service/acm/#ACM.ImportCertificate
Interesting idea. Maybe this could be implemented via:
certificate
, certificate_chain
, and private_key
attributesCustomizeDiff
to fail plan time validation if one of the new attributes is defined but another one is missing OR if validation_method
is missingOptional: true
on validation_method
attributeConflictsWith: []string{"private_key"}
on existing attributes domain_name
, subject_alternative_names
, and validation_method
d.GetOk("private_key")
then call ImportCertificateFor the acceptance testing, we could probably get away with using the TLS provider to generate self-signed certificates to import
This would be a really nice improvement since ACM seems to support the in-place update of the certificate.
Yes please, I'd like the ability to import my Certificates using Terraform, otherwise it's a mess of having to perform an outside API call to do it...
Yes, please. Otherwise we have to bounce out of terraform to do this elsewhere and then come back.
This is not a slight against anyone who posted here (I promise!), but we are now including the following note in our feature request issue template for the repository:
I have a feeling this probably would garner more community/maintainer attention if it were not for the current lack of ๐ reactions on the original issue above. The feature request certainly seems valuable. Unfortunately the upvotes on my comment do not show up in the top level GitHub issue sorting. ๐
As I'm writing this I now feel like we should go back through all the old issues and add that note. It'd
probably be very helpful especially for those not actively working with this project. ๐
This would be a good addition!
Support for ACM importing of certificates (e.g. uploading them) has been merged and will release with version 1.54.0 of the AWS provider, very shortly. ๐
This has been released in version 1.54.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.
I'm going to lock this issue because it has been closed for _30 days_ โณ. This helps our maintainers find and focus on the active issues.
If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!
Most helpful comment
Interesting idea. Maybe this could be implemented via:
certificate
,certificate_chain
, andprivate_key
attributesCustomizeDiff
to fail plan time validation if one of the new attributes is defined but another one is missing OR ifvalidation_method
is missingOptional: true
onvalidation_method
attributeConflictsWith: []string{"private_key"}
on existing attributesdomain_name
,subject_alternative_names
, andvalidation_method
d.GetOk("private_key")
then call ImportCertificateFor the acceptance testing, we could probably get away with using the TLS provider to generate self-signed certificates to import