Terraform-provider-aws: ECS service definition is missing AssignPublicIp property

[afedulov]

Support for network configuration has been added to aws_ecs_service:
https://github.com/terraform-providers/terraform-provider-aws/pull/2299/files

Only security_groups and subnets were added, but assign_public_ip property is missing:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-service-awsvpcconfiguration.html#cfn-ecs-service-awsvpcconfiguration-assignpublicip

This is a blocker for Fargate to pull images from ECR, as it seems that public IP is required (maybe a bug):
https://github.com/aws/amazon-ecs-agent/issues/1128#issuecomment-352090244

Terraform Version

Terraform v0.11.2

Affected Resource(s)

aws_ecs_service

Terraform Configuration Files

resource "aws_ecs_service" "myapp" {
  name            = "myapp"
  cluster         = "fargate"
  launch_type     = "FARGATE"
  network_configuration = {
    subnets = ["${aws_subnet.dev_demo.id}"]
    security_groups = ["${aws_security_group.ecs.id}"]
    assign_public_ip = "ENABLED"        <---- NOT SUPPORTED
  }
...
}

Expected Behavior

Auto-assign public IP ENABLED is applied

Actual Behavior

Error: aws_ecs_service.myapp: network_configuration.0: invalid or unknown key: assign_public_ip

[panuhorsmalahti]

"This is a blocker for Fargate to pull images from ECR, as it seems that public IP is required"

Public IP is not required, as you can use NAT+IGW. However, assigning public ip should of course also be supported.

[afedulov]

@panuhorsmalahti I would appreciate if you could give me advice on how to achieve this here https://github.com/aws/amazon-ecs-agent/issues/1204

[bflad]

Please note the request for adding assign_public_ip to aws_ecs_service is #2873 and an open PR is #2559

[afedulov]

@bflad thanks, I did not notice those.

[johnnorton]

I have finished up the PR and 🤞that everyone is happy, Thanks for your patience.

[bflad]

This has been merged into master and will released with v1.9.0 of the AWS provider, hopefully later today.

[bflad]

This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[sinahwz]

Is 'assign_public_ip' implemented for the windows version also? I am still getting 'invalid or unknown key: assign_public_ip' error.
I am running 'Terraform v0.11.10' on Windows.

[sinahwz]

Is 'assign_public_ip' implemented for the windows version also? I am still getting 'invalid or unknown key: assign_public_ip' error.
I am running 'Terraform v0.11.10' on Windows.

Upgrading the aws provider worked just fine.
'terraform init -upgrade'

[hashibot[bot]]

I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!