Terraform-aws-eks: Worker Groups should support a map of maps

[mcavoyk]

I have issues

I'm submitting a...

• [x] bug report
• [x] feature request
• [ ] support request - read the FAQ first!
• [ ] kudos, thank you, warm fuzzy

What is the current behavior?

Related to https://github.com/terraform-aws-modules/terraform-aws-eks/issues/476, worker_groups and worker_groups_launch_template are both list of maps, as a result removing one worker group can end up causing cycles or changes to all worker groups in the indexes after the modified worker group.

node_groups uses map of maps which allows removal of an element without shifting other elements, this seems like better behavior. A map of map for worker group may also allow for Launch Template/Launch Config as a setting of the worker group rather than a different input as mentioned https://github.com/terraform-aws-modules/terraform-aws-eks/issues/563.

[max-rocket-internet]

node_groups uses map of maps which allows removal of an element without shifting other elements, this seems like better behavior

It is better but worker_groups and worker_groups_launch_template were made before map of maps was possible, pre TF 0.12.

I think this change would be breaking? We should also just merge worker_groups and worker_groups_launch_template together.

[dpiddockcmp]

Could move it all to a submodule at the same time.

Such a breaking change that it would be easier for users to target create resources in the submodule, taint and drain the old nodes, then do a full apply to clean up the old ASGs.

One big round of pain to remove some old headaches?

[max-rocket-internet]

Good idea @dpiddockcmp

[josh-stableprice]

I'm glad to see this is being considered, and as I'm someone who is experiencing this cycle from trying to remove an item from worker group launch template, how do you typically deal with it?

Edit, found it: https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/docs/faq.md#how-do-i-safely-remove-old-worker-groups

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[johnpekcan]

Thanks for removing stale @barryib 😇

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Xyaren]

Nononono... This is still a Problem :) Bad Bot !
Please don't let this go down in other Issues

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[johnpekcan]

bump for stale 😇