Terra-core: Add <pre> tags to improve readability

Created on 30 Aug 2017  路  7Comments  路  Source: cerner/terra-core

Issue Description

Some component's props are of type shape. The props table displays these object structures, but they are not easily readable if the shape is large. Adding the <pre> tags around the output would improve readability.

Issue Type

  • [ ] New Feature
  • [x] Enhancement
  • [ ] Bug
  • [ ] Other

Expected Behavior

screen shot 2017-08-30 at 10 30 33 am

Current Behavior

screen shot 2017-08-30 at 10 28 43 am

Most helpful comment

I will be working on this issue

All 7 comments

I will be working on this issue

@emilyrohrbough is this enhancement to add <pre> tag on all table columns or just type and Description columns data? as those are the two columns that can possibly have large data?

Looks like pre tag has some styling with gray background, below image will shows how it will look after code changes.

pre-tag

I personally don't like gray background on pre tag in a row that contains white background (referring to one of type row in screen shot) let me know if thats acceptable or we need to update background of pre tag accordingly.

I agree. I think we will want to update the background of any pre tags that occur in a white row. Additionally, it seems the pre tag is adding addition bottom-margin that can also be removed.

Let's move forward with a PR for this. We can address the pre background color in another PR.

Resolved in #873

Was this page helpful?
0 / 5 - 0 ratings