Terminal: Profiles not appearing

[eluchsinger]

Environment

Terminal Version: 1.4.3141.0

Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.20236.0 Microsoft Windows NT 10.0.20236.0

Steps to reproduce

I have created a new profile called My Custom Profile in settings.json. The profile does not appear in the dropdown to select profiles.

settings.json

// This file was initially generated by Windows Terminal 1.4.3141.0
// It should still be usable in newer versions, but newer versions might have additional
// settings, help text, or changes that you will not see unless you clear this file
// and let us generate a new one for you.
// To view the default settings, hold "alt" while clicking on the "Settings" button.
// For documentation on these settings, see: https://aka.ms/terminal-documentation
{
    "$schema": "https://aka.ms/terminal-profiles-schema",
    "defaultProfile": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
    // You can add more global application settings here.
    // To learn more about global settings, visit https://aka.ms/terminal-global-settings
    // If enabled, selections are automatically copied to your clipboard.
    "copyOnSelect": false,
    // If enabled, formatted data is also copied to your clipboard
    "copyFormatting": false,
    // A profile specifies a command to execute paired with information about how it should look and feel.
    // Each one of them will appear in the 'New Tab' dropdown,
    //   and can be invoked from the commandline with `wt.exe -p xxx`
    // To learn more about profiles, visit https://aka.ms/terminal-profile-settings
    "profiles": {
        "defaults": {
            // Put settings here that you want to apply to all profiles.
        },
        "list": [
            {
                // Make changes here to the powershell.exe profile.
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Windows PowerShell",
                "commandline": "powershell.exe",
                "hidden": true
            },
            {
                // Make changes here to the cmd.exe profile.
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "name": "Command Prompt",
                "commandline": "cmd.exe",
                "hidden": true
            },
            {
                "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
                "hidden": false,
                "name": "PowerShell",
                "source": "Windows.Terminal.PowershellCore"
            },
            {
                "guid": "{8c10629e-2cb4-4bd8-8d76-858c7f2f61f4}",
                "hidden": false,
                "name": "My Custom PowerShell",
                "source": "Windows.Terminal.PowershellCore"
            },
            {
                "guid": "{b453ae62-4e3d-5e58-b989-0a998ec441b8}",
                "hidden": false,
                "name": "Azure Cloud Shell",
                "source": "Windows.Terminal.Azure"
            }
        ]
    },
    // Add custom color schemes to this array.
    // To learn more about color schemes, visit https://aka.ms/terminal-color-schemes
    "schemes": [],
    // Add custom actions and keybindings to this array.
    // To unbind a key combination from your defaults.json, set the command to "unbound".
    // To learn more about actions and keybindings, visit https://aka.ms/terminal-keybindings
    "actions": [
        // Copy and paste are bound to Ctrl+Shift+C and Ctrl+Shift+V in your defaults.json.
        // These two lines additionally bind them to Ctrl+C and Ctrl+V.
        // To learn more about selection, visit https://aka.ms/terminal-selection
        {
            "command": {
                "action": "copy",
                "singleLine": false
            },
            "keys": "ctrl+c"
        },
        {
            "command": "paste",
            "keys": "ctrl+v"
        },
        // Press Ctrl+Shift+F to open the search box
        {
            "command": "find",
            "keys": "ctrl+shift+f"
        },
        // Press Alt+Shift+D to open a new pane.
        // - "split": "auto" makes this pane open in the direction that provides the most surface area.
        // - "splitMode": "duplicate" makes the new pane use the focused pane's profile.
        // To learn more about panes, visit https://aka.ms/terminal-panes
        {
            "command": {
                "action": "splitPane",
                "split": "auto",
                "splitMode": "duplicate"
            },
            "keys": "alt+shift+d"
        }
    ]
}

Expected behavior

The profile My Custom Profile should appear in the dropdowns to select the profile.

Actual behavior

The profile My Custom Profile does not show up in the dropdown to select the profile.

[skyline75489]

I'm wildly guessing that right now we may not allow a second profile with "source": "Windows.Terminal.PowershellCore", since it's auto-generated.

[eluchsinger]

@skyline75489 trying it with cmd.exe instead of Windows.Terminal.PowershellCore yields the same result.

The current Terminal Preview behaves the same, btw.

[Don-Vito]

@eluchsinger - the source field is reserved for dynamic profiles (https://docs.microsoft.com/en-us/windows/terminal/dynamic-profiles).

If you want to create your custom power shell core you should do something like:

{
   "guid": "{8c10629e-2cb4-4bd8-8d76-858c7f2f61f4}",
   "hidden": false,
   "name": "My Custom PowerShell",                
   "commandline": "pwsh.exe"
}

[eluchsinger]

@Don-Vito works! Is this documented somewhere?

[Don-Vito]

@Don-Vito works! Is this documented somewhere?

I found only https://docs.microsoft.com/en-us/windows/terminal/customize-settings/profile-settings#source which says:

This stores the name of the profile generator that originated the profile. There are no discoverable values for this field. For additional information on dynamic profiles, visit the Dynamic profiles page.

I guess this is not very intuitive.

I knew the answer only since I made some code contribution in an adjacent area, but probably the team can guide to some additional documentation.

[DHowett]

Sorry about that. We're hoping to make this a little more intuitive with #1564 as well.

@Don-Vito, thanks for working on the docs here. I'm gonna close out this version and review your PR over there. :smile: