Terminal: Azure Cloud Shell has acrylic on with default settings

[jim-liu]

Environment

Windows build number: 2004 build 19041
Windows Terminal version (if applicable): 1.1.2021

Steps to reproduce

1. In settings.json, make sure nothing is inside profiles.defaults
2. In Windows Terminal, open a Windows PowerShell tab, and notice that acrylic is off
3. Open an Azure Cloud Shell tab, and notice that acrylic is on
4. In Settings.json, set profiles.defaults.useAcrylic to false
5. Switch back to the Azure Cloud Shell tab, and notice that acrylic is off

Expected behavior

Because https://aka.ms/terminal-profiles-schema states that profiles.defaults.useAcrylic defaults to false, I expect/assume an Azure Cloud Shell tab would have acrylic off by default.

Actual behavior

Azure Cloud Shell tabs have acrylic on by default.

[KalleOlaviNiemitalo]

I was surprised to see acrylic there.

https://github.com/microsoft/terminal/blob/fda80eaf64b6f4bb41f248f5c6b355d672ad64f8/src/cascadia/TerminalApp/AzureCloudShellGenerator.cpp#L39-L41

If the non-default color scheme and acrylic are required by some branding guideline, then perhaps Windows Terminal should write those settings of the Azure Cloud Shell profile to settings.json when it creates that file. Doing so would at least make it easier to understand which settings are making Azure Cloud Shell look different from other profiles.

[DHowett]

Fair points.

[KnapSac]

I'd like to take a look at fixing this, should the acrylic settings be written to the settings.json file, or should they be removed entirely?

[DHowett]

Meh, you can probably just remove it from the Azure generator and be done with it :smile:

[msftbot[bot]]

:tada:This issue was addressed in #7573, which has now been successfully released as Windows Terminal v1.3.2651.0.:tada:

Handy links:

• Release Notes
• Store Download

[msftbot[bot]]

:tada:This issue was addressed in #7573, which has now been successfully released as Windows Terminal Preview v1.4.2652.0.:tada:

Handy links:

• Release Notes
• Store Download