Terminal: Terminal freezes after tab close

[victoralvesp]

Environment

Windows build number: 18363
Windows Terminal version (if applicable): 0.11.1251.0

I'm running Terminal with Powershell Core 7.1.0 preview2

Steps to reproduce

1. Run Terminal
2. Activate fullscreen
3. Open new tab
4. Switch to previous tab
5. Close tab (I use a Ctrl+W binding to close tab)

Expected behavior

Tab closes and focus goes to recently opened tab.

Actual behavior

Sometimes the whole terminal will freeze and the only way to continue is to kill Terminal process

[DHowett-MSFT]

Thanks! This looks like a /dupe of #5559, and I finally got it under the debugger.

[msftbot[bot]]

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

[DHowett-MSFT]

Nevermind, it doesn't look like that dupe.

[DHowett-MSFT]

Oh no. It looks like the TabView never notifies us that its selection changed because it's invisible... We end up directing input into a TerminalControl that's on-screen but _just dead_.

Since the terminal control handles all app key bindings, the app stops responding. If you press F7 when it's in this state, it'll attempt to send F7 to a dead connection and then it'll crash.

[DHowett-MSFT]

/cc @zadjii-msft for if he has any clever ideas around getting out of this sitch

[zadjii-msft]

Oh uh yea I do have a clever idea - while I was trying to figure out a clever idea, I kinda accidentally the whole thing. Sorry to step on your toes here 😬

[MohammatMajken]

I have reproduced the steps, and I must say that whoever found this mistake did a good job.
@zadjii-msft When will the solution come? I can't wait! 😊

[MohammatMajken]

By the way, good work!

[zadjii-msft]

I'm not really sure what the timeline for this fix will be - it _might_ get pulled into Terminal 1.0. The bot will come through and post on this issue when it _does_ get released, that's for sure ☺️

[victoralvesp]

That was quick! Thanks for the great work!

[msftbot[bot]]

:tada:This issue was addressed in #5809, which has now been successfully released as Windows Terminal Release Candidate v0.11.1333.0 (1.0rc2).:tada:

Handy links:

• Release Notes
• Store Download