Terminal: Support fullscreening with Win+Shift+Enter

[xmha97]

Hello, I know this app will full-screen with Alt+Enter and F11
Please add a new keyboard shortcut for full-screen: Win+Shift+Enter
Why?! Because all universal apps became full-screen with Win+Shift+Enter
Thanks.

[zadjii-msft]

I suppose if other UWP apps use this keybinding, then we could too. The system already set a precedent that this key chord is used for that, so we could use it too, I don't feel bad about hijacking it in this case.

[DHowett-MSFT]

Yeah, I don't see why not.

[abhijeetviswam]

I was trying to work this out, however I found that currently there is no support for windows key modifier. Also based on comments in #4329, there's no plan to implement it.

I'm wondering how we can bring in this feature if the modifier cannot be added. Does the terminal support any win key based shortcuts right now?

[zadjii-msft]

Since Win+Shift+Enter is a _system_ keybinding that's usually bound to fullscreen UWP applications, we can special-case that keybinding to fullscreen the Terminal, so it behaves like other apps on the system. It would not be a general-purpose "users can bind the Win key", it would be a one-off special case.

[neville-nazerane]

Powershell and command prompt have fullscreen on alt + shift + enter. How about staying consistent with them?

[DHowett]

Uh, powershell and command prompt have fullscreen on _alt+enter_. Terminal does too. It works today.

[neville-nazerane]

By habit from visual studio I always only tried alt + shift + enter. Never realized just shift + enter worked. Makes sense now, Thanks!

So basically, in that case, there is kind of a bug where holding an additional key doesn't work in the terminal but does in command prompt and powershell.