Terminal: Provide Windows version in the about box

[teobugslayer]

Description of the new feature/enhancement

To simplify bug reporting, please provide the version you request from the community in one place.

I suggest adding the windows version in WT's About box and let the users easily copy/paste it in the GitHub issues.

[zadjii-msft]

This is actually something we've had in the terminal since the first public release...

/dup #867 #1196 #1335 #1452

[msftbot[bot]]

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

[DHowett-MSFT]

This one actually looks like a request for the _OS version_, which does seem useful.

[teobugslayer]

Yep, I meant to ask to show the OS version, which is required to submit a Github issue. Just saving one annopying step in the process.

[mkitzan]

I'll look into an implementation for this

[mkitzan]

What OS version formatting would be most helpful for the dev team so users could just copy-paste the text in their issue post?
Also, in my draft implementation I introduce a new private function to TerminalPage to handle getting the Windows version. The function seems out of place in TerminalPage though. CascadiaSettings might be a better location for this function considering it's a data member of TerminalPage. Any ideas of a better location for this function?
Here's the commit with the full implementation. Any feedback before the PR would be great!

[zadjii-msft]

@mkitzan Honestly that looks pretty good to me. I probably wouldn't even move the _GetWindowsVersion function, since the TerminalPage is generally responsible for building the rest of that dialog, I think it fits well there.

[mkitzan]

Sounds good, I'll make a PR for this fix.

[mdtauk]

Is the full build number needed, over say the 1909 versioning?

[DHowett-MSFT]

@mdtauk since we are the windows console team, and the console subsystem is part of windows, and it can be serviced with an update I’m going to say _yes absolutely_

[mdtauk]

@mdtauk since we are the windows console team, and the console subsystem is part of windows, and it can be serviced with an update I’m going to say _yes absolutely_

Good good! Perfect justification.

[zadjii-msft]

Hey there's a really long conversation in #3696 about why we're not doing this. If anyone's interested in the reasons why, go read that PR. Thanks!