Terminal: Blacklist Docker for Windows WSL2 Service Machines

Created on 13 Nov 2019 · 7Comments · Source: microsoft/terminal

Description of the new feature/enhancement

The latest version of Docker for Windows is adding a WSL2-based backend powered by a series of service machines. Terminal currently discovers these and adds them as options that the user can select. These should probably be blacklisted from being presented to the user in the short-term. I imagine a better long-term solution is for WSL2 to be able to use metadata to differentiate service-machines from user-created machines that I might want to log into.

  [
  ...
        {
            "guid": "{d8afdc0e-a636-5b68-89dd-50a9d0b54349}",
            "hidden": false,
            "name": "docker-desktop-data",
            "source": "Windows.Terminal.Wsl"
        },
        {
            "guid": "{570fcb8d-792c-5ac7-ab1f-5cfb2cdfdb99}",
            "hidden": false,
            "name": "docker-desktop",
            "source": "Windows.Terminal.Wsl"
        }
  ],

Proposed technical implementation details (optional)

Area-Settings Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed

Source

bushidocodes

👍3

Most helpful comment

As a workaround, I set these profiles as hidden:

    {
        "guid": "{570fcb8d-792c-5ac7-ab1f-5cfb2cdfdb99}",
        "hidden": true,
        "name": "docker-desktop",
        "source": "Windows.Terminal.Wsl"
    },
    {
        "guid": "{d8afdc0e-a636-5b68-89dd-50a9d0b54349}",
        "hidden": true,
        "name": "docker-desktop-data",
        "source": "Windows.Terminal.Wsl"
    }

Maybe docker backend could be hidden as default...

gmsantos on 13 Nov 2019

👍4

All 7 comments

Ugh. I knew this day would come!

@benhill should we just, like, match the name or something? That seems bad.

DHowett on 13 Nov 2019

@benhillis is the right one 😉

zadjii-msft on 13 Nov 2019

I don't have a strong opinion, but a blacklist doesn't seem like a terrible idea.

benhillis on 13 Nov 2019

Sorry about tagging you into a random issue, wrong-Ben.

A disallow list doesn't sound terrible. I mean, it 100% does sound terrible, but it doesn't sound _awful_.

DHowett-MSFT on 13 Nov 2019

👍1

Semantics :)

I don't like it either, I just think it's really our only choice.

benhillis on 13 Nov 2019

As a workaround, I set these profiles as hidden:

    {
        "guid": "{570fcb8d-792c-5ac7-ab1f-5cfb2cdfdb99}",
        "hidden": true,
        "name": "docker-desktop",
        "source": "Windows.Terminal.Wsl"
    },
    {
        "guid": "{d8afdc0e-a636-5b68-89dd-50a9d0b54349}",
        "hidden": true,
        "name": "docker-desktop-data",
        "source": "Windows.Terminal.Wsl"
    }

Maybe docker backend could be hidden as default...

gmsantos on 13 Nov 2019

👍4

:tada:This issue was addressed in #4156, which has now been successfully released as Windows Terminal Preview v0.8.10091.0.:tada:

Handy links: