Terminal: "Close all tabs?" dialog should highlight the "default" option

Created on 30 Oct 2019  路  6Comments  路  Source: microsoft/terminal

refer to screenshot:

image

Pressing enter here _closes the window_, because that's the focused/default button on this dialog. However, there's no way of knowing which is the selected button right now. We should either use the accent color with the button, or manually display the focus rect (is that even possible)?

Also for discussion: Should "close" be the default option here?

Area-User Interface Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal Resolution-Fix-Committed v1-Scrubbed

All 6 comments

Gut feeling: cancel should be the default option.

Classic Edge:
image

Pressing Enter does trigger "Close all". Surprisingly, they don't make it clear that that's the default button here. We definitely should though.

On a separate note, consider adding that checkbox? (that should definitely be it's own issue though)

You could use the Accented Button style for the default option

My opinion is that you should use the focus rectangle.

When you only have two buttons and they are different colors it is still not clear which one is active.

Along with this issue, the styling should be fixed as well to match the other dialog boxes.
Mockup proposal:
image

In terms of what should be default, I'd argue if we have the checkbox for "don't show this again", it should be Cancel. Otherwise, Close All Tabs should be default.

:tada:This issue was addressed in #4401, which has now been successfully released as Windows Terminal Preview v0.9.433.0.:tada:

Handy links:

Was this page helpful?
0 / 5 - 0 ratings