Terminal: Duplicate shell entries in the drop down

[clairernovotny]

Environment

Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.18995.0 Microsoft Windows NT 10.0.18995.0

Windows Terminal version (if applicable): nightly build from Oct 3

Any other software?

Steps to reproduce

Add another profile in the json. Drop down shows too many.

Expected behavior

The list of profiles in the drop down should match the profiles.json

Actual behavior

An extra entry is in the list. There is no profile 5. What's strange is that when I launch that bogus profile, it doesn't look like the one I set up:

The "real" profile for Windows PowerShell looks like this:

Here's the profile list as shown by Terminal. Note the extra bogus profile that's not in the profiles.json

```profiles.json
{
"$schema": "https://aka.ms/terminal-profiles-schema",
"globals" :
{
"alwaysShowTabs" : true,
"defaultProfile" : "{5fa4ec8f-b1ff-4d94-b239-1321ccccc69b}",
"initialCols" : 120,
"initialRows" : 40,
"keybindings" :
[
{
"command" : "closeTab",
"keys" :
[
"ctrl+w"
]
},
{
"command" : "newTab",
"keys" :
[
"ctrl+t"
]
},
{
"command" : "newTabProfile0",
"keys" :
[
"ctrl+shift+1"
]
},
{
"command" : "newTabProfile1",
"keys" :
[
"ctrl+shift+2"
]
},
{
"command" : "newTabProfile2",
"keys" :
[
"ctrl+shift+3"
]
},
{
"command" : "newTabProfile3",
"keys" :
[
"ctrl+shift+4"
]
},
{
"command" : "newTabProfile4",
"keys" :
[
"ctrl+shift+5"
]
},
{
"command" : "newTabProfile5",
"keys" :
[
"ctrl+shift+6"
]
},
{
"command" : "newTabProfile6",
"keys" :
[
"ctrl+shift+7"
]
},
{
"command" : "newTabProfile7",
"keys" :
[
"ctrl+shift+8"
]
},
{
"command" : "newTabProfile8",
"keys" :
[
"ctrl+shift+9"
]
},
{
"command" : "nextTab",
"keys" :
[
"ctrl+tab"
]
},
{
"command" : "prevTab",
"keys" :
[
"ctrl+shift+tab"
]
},
{
"command" : "scrollDown",
"keys" :
[
"ctrl+shift+down"
]
},
{
"command" : "scrollDownPage",
"keys" :
[
"ctrl+shift+pgdn"
]
},
{
"command" : "scrollUp",
"keys" :
[
"ctrl+shift+up"
]
},
{
"command" : "scrollUpPage",
"keys" :
[
"ctrl+shift+pgup"
]
},
{
"command" : "switchToTab0",
"keys" :
[
"alt+1"
]
},
{
"command" : "switchToTab1",
"keys" :
[
"alt+2"
]
},
{
"command" : "switchToTab2",
"keys" :
[
"alt+3"
]
},
{
"command" : "switchToTab3",
"keys" :
[
"alt+4"
]
},
{
"command" : "switchToTab4",
"keys" :
[
"alt+5"
]
},
{
"command" : "switchToTab5",
"keys" :
[
"alt+6"
]
},
{
"command" : "switchToTab6",
"keys" :
[
"alt+7"
]
},
{
"command" : "switchToTab7",
"keys" :
[
"alt+8"
]
},
{
"command" : "switchToTab8",
"keys" :
[
"alt+9"
]
}
],
"requestedTheme" : "system",
"showTabsInTitlebar" : true,
"showTerminalTitleInTitlebar" : true,
"wordDelimiters" : " ./\()\"'-:,.;<>~!@#$%^&*|+=[]{}~?\u2502"
},
"profiles": [
{
"acrylicOpacity": 0.75,
"background": "#2E3436",
"closeOnExit": true,
"colorScheme": "Ubuntu (Brad)",
"commandline": "C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe",
"cursorColor": "#B5BBAE",
"cursorShape": "bar",
"fontFace": "UbuntuMono NF",
"fontSize": 10,
"guid": "{5fa4ec8f-b1ff-4d94-b239-1321ccccc69a}",
"historySize": 9001,
"icon": "ms-appx:///ProfileIcons/{61c54bbd-c2c6-5271-96e7-009a87ff44bf}.png",
"name": "Windows PowerShell",
"padding": "0, 0, 0, 0",
"snapOnInput": true,
"startingDirectory": "d:\dev",
"useAcrylic": true
},
{
"acrylicOpacity": 0.75,
"closeOnExit": true,
"colorScheme": "Campbell",
"commandline": "cmd.exe",
"cursorColor": "#FFFFFF",
"cursorShape": "bar",
"fontFace": "Consolas",
"fontSize": 10,
"guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
"historySize": 9001,
"icon": "ms-appx:///ProfileIcons/{0caa0dad-35be-5f56-a8ff-afceeeaa6101}.png",
"name": "cmd",
"padding": "0, 0, 0, 0",
"snapOnInput": true,
"startingDirectory": "d:\dev",
"useAcrylic": true
},
{
"acrylicOpacity": 0.5,
"closeOnExit": true,
"colorScheme": "Campbell",
"commandline": "wsl.exe -d Ubuntu",
"cursorColor": "#FFFFFF",
"cursorShape": "bar",
"fontFace": "Consolas",
"fontSize": 10,
"guid": "{2c4de342-38b7-51cf-b940-2309a097f518}",
"historySize": 9001,
"icon": "ms-appx:///ProfileIcons/{9acb9455-ca41-5af7-950f-6bca1bc9722f}.png",
"name": "Ubuntu",
"padding": "0, 0, 0, 0",
"snapOnInput": true,
"startingDirectory": "d:\dev",
"useAcrylic": false
},
{
"acrylicOpacity": 0.75,
"background": "#2E3436",
"closeOnExit": true,
"colorScheme": "Ubuntu (Brad)",
"commandline": "pwsh.exe",
"cursorColor": "#B5BBAE",
"cursorShape": "bar",
"fontFace": "UbuntuMono NF",
"fontSize": 10,
"guid": "{5fa4ec8f-b1ff-4d94-b239-1321ccccc69b}",
"historySize": 9001,
"icon": "ms-appx:///ProfileIcons/{574e775e-4f2a-5b96-ac1e-a2962a402336}.png",
"name": "PowerShell Core",
"padding": "0, 0, 0, 0",
"snapOnInput": true,
"startingDirectory": "d:\dev",
"useAcrylic": true
}

],
"schemes" :
[
{
"background" : "#2E3436",
"black" : "#2E3436",
"blue" : "#3465A4",
"brightBlack" : "#696B67",
"brightBlue" : "#729FCF",
"brightCyan" : "#34E2E2",
"brightGreen" : "#8AE234",
"brightPurple" : "#AD7FA8",
"brightRed" : "#F49797",
"brightWhite" : "#FBFBFB",
"brightYellow" : "#FCE94F",
"cyan" : "#06989A",
"foreground" : "#B5BBAE",
"green" : "#4E9A06",
"name" : "Ubuntu (Brad)",
"purple" : "#75507B",
"red" : "#AE5E5E",
"white" : "#B5BBAE",
"yellow" : "#C4A000"
},
{
"background" : "#0C0C0C",
"black" : "#0C0C0C",
"blue" : "#0037DA",
"brightBlack" : "#767676",
"brightBlue" : "#3B78FF",
"brightCyan" : "#61D6D6",
"brightGreen" : "#16C60C",
"brightPurple" : "#B4009E",
"brightRed" : "#E74856",
"brightWhite" : "#F2F2F2",
"brightYellow" : "#F9F1A5",
"cyan" : "#3A96DD",
"foreground" : "#F2F2F2",
"green" : "#13A10E",
"name" : "Campbell",
"purple" : "#881798",
"red" : "#C50F1F",
"white" : "#CCCCCC",
"yellow" : "#C19C00"
},
{
"background" : "#282C34",
"black" : "#282C34",
"blue" : "#61AFEF",
"brightBlack" : "#5A6374",
"brightBlue" : "#61AFEF",
"brightCyan" : "#56B6C2",
"brightGreen" : "#98C379",
"brightPurple" : "#C678DD",
"brightRed" : "#E06C75",
"brightWhite" : "#DCDFE4",
"brightYellow" : "#E5C07B",
"cyan" : "#56B6C2",
"foreground" : "#DCDFE4",
"green" : "#98C379",
"name" : "One Half Dark",
"purple" : "#C678DD",
"red" : "#E06C75",
"white" : "#DCDFE4",
"yellow" : "#E5C07B"
},
{
"background" : "#FAFAFA",
"black" : "#383A42",
"blue" : "#0184BC",
"brightBlack" : "#4F525D",
"brightBlue" : "#61AFEF",
"brightCyan" : "#56B5C1",
"brightGreen" : "#98C379",
"brightPurple" : "#C577DD",
"brightRed" : "#DF6C75",
"brightWhite" : "#FFFFFF",
"brightYellow" : "#E4C07A",
"cyan" : "#0997B3",
"foreground" : "#383A42",
"green" : "#50A14F",
"name" : "One Half Light",
"purple" : "#A626A4",
"red" : "#E45649",
"white" : "#FAFAFA",
"yellow" : "#C18301"
},
{
"background" : "#073642",
"black" : "#073642",
"blue" : "#268BD2",
"brightBlack" : "#002B36",
"brightBlue" : "#839496",
"brightCyan" : "#93A1A1",
"brightGreen" : "#586E75",
"brightPurple" : "#6C71C4",
"brightRed" : "#CB4B16",
"brightWhite" : "#FDF6E3",
"brightYellow" : "#657B83",
"cyan" : "#2AA198",
"foreground" : "#FDF6E3",
"green" : "#859900",
"name" : "Solarized Dark",
"purple" : "#D33682",
"red" : "#D30102",
"white" : "#EEE8D5",
"yellow" : "#B58900"
},
{
"background" : "#FDF6E3",
"black" : "#073642",
"blue" : "#268BD2",
"brightBlack" : "#002B36",
"brightBlue" : "#839496",
"brightCyan" : "#93A1A1",
"brightGreen" : "#586E75",
"brightPurple" : "#6C71C4",
"brightRed" : "#CB4B16",
"brightWhite" : "#FDF6E3",
"brightYellow" : "#657B83",
"cyan" : "#2AA198",
"foreground" : "#073642",
"green" : "#859900",
"name" : "Solarized Light",
"purple" : "#D33682",
"red" : "#D30102",
"white" : "#EEE8D5",
"yellow" : "#B58900"
}
]
}
```

[DHowett-MSFT]

Hey @onovotny, we touched on this in the 0.5 release notes a bit. Your Windows PowerShell profile's guid doesn't match the "default" one (hold down Alt and click on Settings), so it's technically a different profile. If you'd like to override the default profile or reorder it, copy its guid over yours -- or just delete yours if you don't have any custom settings.

[DHowett-MSFT]

You'll probably also see a duplicate pwsh.exe, eventually (if you install one in Program Files) -- the reason is the same.

[clairernovotny]

Might be worth a "reset to defaults" gesture in the UI? This wasn't really discoverable...

[DHowett-MSFT]

That's a fair request. I think that on account of we're _0.5_ and our settings model hasn't been declared stable, it's also not unfair to expect users to absorb some amount of "please delete your file to get back to the defaults."

Moving forward, our "defaults" are _way way_ better. It does glorious things if you delete profiles.json today.

[zadjii-msft]

Also, there's #947 for that request :)

[DHowett-MSFT]

(Thanks for the suggestion! I know we'll need it going forward, and I think we have a backlog item for it. I can't find it at the moment.)

[DHowett-MSFT]

Ding!