Terminal: Use JSONC / allow comments in JSON per other Microsoft products
Windows 10.0.18362.0, Terminal Preview 3.
I needed to add a comment explaining why I'd disabled a config option
This is correct, comments aren't permitted in JSON. Terminal, like vsCode, should use JSONC (whether it has a .json or .jsonc extension):
I know Code and Terminal are different teams but consistency would be good here, and comments are useful.
mikemaccana
All 4 comments
We actually do allow comments in the json file as of #1005. Dunno why VS Code is tagging the file like that, but they're definitely allowed.
zadjii-msft
on 6 Aug 2019
OK I'll file it with vscode. 馃憤馃徏
mikemaccana
on 6 Aug 2019
It highlights it like this because things with a .json extension are supposed to be JSON and not JSONC. Adding an exception in VS Code will only fix it there, not for any other editor. The file should be renamed to reflect its real type.
flying-sheep
on 16 Jan 2020
@zadjii-msft The settings.json file of Windows Terminal is not a valid JSON, so it will alert linters in most code editors. Why don't you rename the file to settings.jsonc?
wetterkrank
on 28 Jul 2020
Related issues
mrmlnc
路
3Comments
mdtauk
路
3Comments
miniksa
路
3Comments
geeksfn
路
3Comments
carlos-zamora
路
3Comments
Most helpful comment
It highlights it like this because things with a
.jsonextension are supposed to be JSON and not JSONC. Adding an exception in VS Code will only fix it there, not for any other editor. The file should be renamed to reflect its real type.