Terminal: New terminal does not handle theme change event.

[zadjii-msft]

From MSFT:21424988
I have to restart the new terminal to see the effects of changing between light and dark windows theme.
You can see at the attached screenshot that the tabs haven't changed it's colors after I changed from Dark to Light theme. UWP apps are supposed to do that by default.

[DHowett-MSFT]

This one is interesting. We could probably tackle it as part of #1125, but maybe we want to keep it separate?

[Aarklendoia]

The window border as well as the area with the Minimize, Maximize and Close buttons does not take the color of the theme (remains white despite the dark theme).

[Aarklendoia]

[Mercurial]

same here , anyone know how to fix this?

[DHowett-MSFT]

To be blunt: somebody needs to write the code to do this. If we do it, it will come out whenever we are done. If we don’t, we will get back to it eventually.

[AnuthaDev]

@DHowett May I work on it??

[DHowett]

@AnuthaDev you certainly may :smile:

[StefanScherer]

Yes please change the window title according to the dark/light theme in Windows. I also have to close and re-open the terminal to fully switch. The theme itself I change the settings.json at the moment, configuring two themes, one for dark, another for light and let it auto-switch according to Windows theme would be even better.

[mdtauk]

Not sure if this is a XAML Island thing, but if you are using Xaml ThemeResources - they should update and refresh as the RequestedTheme changes.

[zadjii-msft]

This is almost _certainly_ Islands related. I'm not sure what window message is sent when the theme changes, but there almost certainly should be one...

[AnuthaDev]

@zadjii-msft I think it's this one: WM_SETTINGCHANGE